Catch errors on content scan #150
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #149.
Previously, when there was any error in
ContentControl.init(which basically calls every otherinit), the_initializeCompleterwould have never been completed, which either caused and endless search spinner if the user just granted permissions, or it would case the app to get stuck on the splash screen, which was really unpleasant.Now we catch any errors and make sure to complete the
_initializeCompleter. When an error occurred, we would just show the "no songs" screen, which I think is unhelpful, so I added an error screen.This implements the second checkbox of #127.