-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all GitHub actions dependencies #153
Conversation
As a side note, we might want to set up dependabot to keep these up to date in the future. |
FYI secrets must be passed explicitly to actions You can see an example here https://github.com/nt4f04uNd/sweyer/blob/master/.github/workflows/deploy_google_play/action.yml#L30 |
Ups, I totally missed that part, thanks for double checking.
Yeah, the main repository now requires a token, but forks can continue to use tokenless upload (From the codecov actions
I think we can just merge and verify that the CI on the merge commit works, and iterate on it in a follow up PR if anything breaks. |
Ah, you are saying the files included with |
Can you open an issue? |
Done: #155 |
This updates our CI dependencies. I read through the change logs and made sure that there are no breaking changes for us.
There is one exception:
codecov/codecov-action@v4
removes tokenless uploads of coverage information. This means that we need to make sure that we have configured our Codecov token in the GitHub repository settings as described in the documentation. I don't have access to these settings so only you can do that.Hopefully the update will fix the Codecov upload failures we've seen on recent CI runs like here.