Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

probability normalization in exp4.p #65

Open
ianlini opened this issue Sep 12, 2016 · 4 comments
Open

probability normalization in exp4.p #65

ianlini opened this issue Sep 12, 2016 · 4 comments
Labels

Comments

@ianlini
Copy link
Collaborator

ianlini commented Sep 12, 2016

https://github.com/ntucllab/striatum/blob/master/striatum/bandit/exp4p.py#L102
This normalization is not in the paper. Is this correct?

@ianlini
Copy link
Collaborator Author

ianlini commented Sep 12, 2016

I think this only transform query_vector to be np.ndarray?

@taweihuang
Copy link
Contributor

taweihuang commented Sep 12, 2016

sum(query_vector) should be 1 form the theoretical aspect, but in python there may be some numerical errors so that the sum(query_vector) will be slightly larger or smaller than 1. So I further add this line to make sure that the sum of query_vector is 1.

@ianlini
Copy link
Collaborator Author

ianlini commented Sep 12, 2016

It transform query_vector to ndarray because every values in query_vector is np.float64, so that division make query_vector to be ndarray.
It's quite unexpected.

@ianlini
Copy link
Collaborator Author

ianlini commented Sep 12, 2016

and why is it called query_vector?
I think action_probability or something like this is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants