Fix CS

phpunit.xml.dist

@@ -1,10 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" backupGlobals="false" colors="true" processIsolation="false" stopOnFailure="false" bootstrap="tests/bootstrap.php" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.0/phpunit.xsd" cacheDirectory=".phpunit.cache">
-  <coverage>
-    <include>
-      <directory suffix=".php">./src/</directory>
-    </include>
-  </coverage>
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" backupGlobals="false" colors="true" processIsolation="false" stopOnFailure="false" bootstrap="tests/bootstrap.php" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd" cacheDirectory=".phpunit.cache">
+  <coverage/>
   <php>
     <env name="SYMFONY_DEPRECATIONS_HELPER" value="max[self]=0"/>
   </php>
@@ -13,4 +9,9 @@
       <directory>./tests/</directory>
     </testsuite>
   </testsuites>
+  <source>
+    <include>
+      <directory suffix=".php">./src/</directory>
+    </include>
+  </source>
 </phpunit>

psalm-baseline.xml

@@ -1,18 +1,18 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="4.6.0@77feecb3707bd50378c21ae4d3fe9e320e6cea65">
+<files psalm-version="5.16.0@2897ba636551a8cb61601cc26f6ccfbba6c36591">
   <file src="src/Block/Service/SpaceStatisticBlockService.php">
-    <ParamNameMismatch occurrences="1">
+    <ParamNameMismatch>
       <code>$formMapper</code>
     </ParamNameMismatch>
   </file>
-  <file src="src/Service/AbstractService.php">
-    <InvalidScalarArgument occurrences="1">
-      <code>$fault-&gt;getCode()</code>
-    </InvalidScalarArgument>
-  </file>
-  <file src="src/Service/AuthService.php">
-    <InvalidScalarArgument occurrences="1">
-      <code>$fault-&gt;getCode()</code>
-    </InvalidScalarArgument>
+  <file src="src/DependencyInjection/Configuration.php">
+    <UndefinedMethod>
+      <code>addDefaultsIfNotSet</code>
+      <code>append</code>
+      <code>append</code>
+      <code>append</code>
+      <code>children</code>
+      <code>fixXmlConfig</code>
+    </UndefinedMethod>
   </file>
 </files>

src/Block/Service/SpaceStatisticBlockService.php

@@ -120,9 +120,7 @@ public function configureSettings(OptionsResolver $resolver): void
         $resolver->setRequired(['login', 'password']);
     }
 
-    public function validate(ErrorElement $errorElement, BlockInterface $block): void
-    {
-    }
+    public function validate(ErrorElement $errorElement, BlockInterface $block): void {}
 
     public function getMetadata(): MetadataInterface
     {

src/Exception/AllInklException.php

@@ -13,6 +13,4 @@
 
 use Exception;
 
-final class AllInklException extends Exception
-{
-}
+final class AllInklException extends Exception {}

src/Resources/config/block.php

@@ -25,6 +25,5 @@
             ->call('setLogger', [
                 new Reference('logger'),
             ])
-
     ;
 };

src/Resources/config/commands.php

@@ -28,6 +28,5 @@
                 new Parameter('nucleos_allinkl.check.accounts'),
                 new Parameter('nucleos_allinkl.check.warning'),
             ])
-
     ;
 };

src/Resources/config/services.php

@@ -43,6 +43,5 @@
             ->args([
                 new Parameter('nucleos_allinkl.api.api_endpoint'),
             ])
-
     ;
 };

src/Service/AbstractService.php

@@ -34,9 +34,6 @@ abstract class AbstractService implements LoggerAwareInterface
      */
     private $endpoint;
 
-    /**
-     * @param string $endpoint
-     */
     public function __construct(string $endpoint = null)
     {
         if (null === $endpoint) {

src/Service/AuthService.php

@@ -23,13 +23,10 @@ final class AuthService extends AbstractService implements AuthServiceInterface
      */
     private const DEFAULT_AUTH_ENDPOINT = 'https://kasapi.kasserver.com/soap/wsdl/KasAuth.wsdl';
 
-    /**
-     * @param string $endpoint
-     */
     public function __construct(string $endpoint = null)
     {
         if (null === $endpoint) {
-            $endpoint = static::DEFAULT_AUTH_ENDPOINT;
+            $endpoint = self::DEFAULT_AUTH_ENDPOINT;
         }
 
         parent::__construct($endpoint);

tests/Block/Service/SpaceStatisticBlockServiceTest.php

@@ -52,17 +52,17 @@ public function testExecute(): void
     {
         $session = new Session('foo', 'token');
 
-        $this->authService->expects(static::once())->method('createSession')
-            ->with(static::equalTo('foologin'), static::equalTo('barpw'))
+        $this->authService->expects(self::once())->method('createSession')
+            ->with(self::equalTo('foologin'), self::equalTo('barpw'))
             ->willReturn($session)
         ;
 
         $dataResponse = [
             ['foo' => 'bar'],
         ];
 
-        $this->statisticService->expects(static::once())->method('getSpace')
-            ->with(static::equalTo($session), true, true)
+        $this->statisticService->expects(self::once())->method('getSpace')
+            ->with(self::equalTo($session), true, true)
             ->willReturn($dataResponse)
         ;
 
@@ -77,7 +77,7 @@ public function testExecute(): void
 
         $response = new Response();
 
-        $this->twig->expects(static::once())->method('render')
+        $this->twig->expects(self::once())->method('render')
             ->with(
                 '@NucleosAllInkl/Block/block_space_statistic.html.twig',
                 [
@@ -96,8 +96,8 @@ public function testExecute(): void
             $this->statisticService
         );
 
-        static::assertSame($response, $blockService->execute($blockContext, $response));
-        static::assertSame('TWIG_CONTENT', $response->getContent());
+        self::assertSame($response, $blockService->execute($blockContext, $response));
+        self::assertSame('TWIG_CONTENT', $response->getContent());
     }
 
     public function testDefaultSettings(): void

tests/BundleIntegrationTest.php

@@ -23,6 +23,6 @@ public function testStartup(): void
 
         $client->request('GET', '/test');
 
-        static::assertSame(200, $client->getResponse()->getStatusCode());
+        self::assertSame(200, $client->getResponse()->getStatusCode());
     }
 }

tests/DependencyInjection/ConfigurationTest.php

@@ -34,7 +34,7 @@ public function testOptions(): void
             ],
         ];
 
-        static::assertSame($expected, $config);
+        self::assertSame($expected, $config);
     }
 
     public function testCronOptions(): void
@@ -75,6 +75,6 @@ public function testCronOptions(): void
             ],
         ];
 
-        static::assertSame($expected, $config);
+        self::assertSame($expected, $config);
     }
 }

tests/NucleosAllInklBundleTest.php

@@ -21,6 +21,6 @@ public function testGetContainerExtension(): void
     {
         $bundle = new NucleosAllInklBundle();
 
-        static::assertInstanceOf(NucleosAllInklExtension::class, $bundle->getContainerExtension());
+        self::assertInstanceOf(NucleosAllInklExtension::class, $bundle->getContainerExtension());
     }
 }