Add type hints #1338
core23continuous-integration.yml
on: pull_request
run
/
Generate test matrix
11s
Matrix: run / Code Coverage
Matrix: run / Coding Standards
Matrix: run / Lint composer.json
Matrix: run / Lint symfony container
Matrix: run / Mutation Tests
Matrix: run / Static Code Analysis
Matrix: run / Lint twig files
Matrix: run / Lint XLIFF files
Matrix: run / Lint YML files
Matrix: run / tests
Annotations
4 errors and 10 warnings
|
run / Static Code Analysis (8.2):
src/EventListener/ORM/SortableListener.php#L184
Cannot call method getValue() on Symfony\Component\PropertyAccess\PropertyAccessor|null.
|
|
run / Static Code Analysis (8.2):
src/EventListener/ORM/UniqueActiveListener.php#L112
Cannot call method getValue() on Symfony\Component\PropertyAccess\PropertyAccessor|null.
|
|
run / Static Code Analysis (8.2):
src/EventListener/ORM/UniqueActiveListener.php#L124
Cannot call method getValue() on Symfony\Component\PropertyAccess\PropertyAccessor|null.
|
|
run / Static Code Analysis (8.2)
Process completed with exit code 2.
|
|
run / Mutation Tests (8.2):
src/EventListener/ORM/LifecycleDateListener.php#L61
Escaped Mutant for Mutator "FalseValue":
--- Original
+++ New
@@ @@
if (null === $reflClass || !$reflClass->implementsInterface(LifecycleDateTimeInterface::class)) {
return;
}
- $this->createDateTimeField($meta, 'createdAt', false);
+ $this->createDateTimeField($meta, 'createdAt', true);
$this->createDateTimeField($meta, 'updatedAt', false);
}
}
|
|
run / Mutation Tests (8.2):
src/EventListener/ORM/LifecycleDateListener.php#L62
Escaped Mutant for Mutator "FalseValue":
--- Original
+++ New
@@ @@
return;
}
$this->createDateTimeField($meta, 'createdAt', false);
- $this->createDateTimeField($meta, 'updatedAt', false);
+ $this->createDateTimeField($meta, 'updatedAt', true);
}
}
|
|
run / Mutation Tests (8.2):
src/EventListener/ORM/SortableListener.php#L58
Escaped Mutant for Mutator "InstanceOf_":
--- Original
+++ New
@@ @@
}
public function prePersist(PrePersistEventArgs $args) : void
{
- if (!$args->getObject() instanceof PositionAwareInterface) {
+ if (!true) {
return;
}
$this->uniquePosition($args);
|
|
run / Mutation Tests (8.2):
src/EventListener/ORM/SortableListener.php#L58
Escaped Mutant for Mutator "InstanceOf_":
--- Original
+++ New
@@ @@
}
public function prePersist(PrePersistEventArgs $args) : void
{
- if (!$args->getObject() instanceof PositionAwareInterface) {
+ if (!false) {
return;
}
$this->uniquePosition($args);
|
|
run / Mutation Tests (8.2):
src/EventListener/ORM/SortableListener.php#L58
Escaped Mutant for Mutator "LogicalNot":
--- Original
+++ New
@@ @@
}
public function prePersist(PrePersistEventArgs $args) : void
{
- if (!$args->getObject() instanceof PositionAwareInterface) {
+ if ($args->getObject() instanceof PositionAwareInterface) {
return;
}
$this->uniquePosition($args);
|
|
run / Mutation Tests (8.2):
src/EventListener/ORM/SortableListener.php#L84
Escaped Mutant for Mutator "InstanceOf_":
--- Original
+++ New
@@ @@
public function preRemove(PreRemoveEventArgs $args) : void
{
$entity = $args->getObject();
- if ($entity instanceof PositionAwareInterface) {
+ if (false) {
$this->movePosition($args->getObjectManager(), $entity, -1);
}
}
|
|
run / Mutation Tests (8.2):
src/EventListener/ORM/UniqueActiveListener.php#L55
Escaped Mutant for Mutator "MethodCallRemoval":
--- Original
+++ New
@@ @@
}
public function prePersist(PrePersistEventArgs $args) : void
{
- $this->uniqueActive($args);
+
}
public function preUpdate(PreUpdateEventArgs $args) : void
{
|
|
run / Mutation Tests (8.2):
src/EventListener/ORM/UniqueActiveListener.php#L60
Escaped Mutant for Mutator "MethodCallRemoval":
--- Original
+++ New
@@ @@
}
public function preUpdate(PreUpdateEventArgs $args) : void
{
- $this->uniqueActive($args);
+
}
/**
* @throws MappingException
|
|
run / Mutation Tests (8.2):
src/EventListener/ORM/UniqueActiveListener.php#L91
Escaped Mutant for Mutator "InstanceOf_":
--- Original
+++ New
@@ @@
private function uniqueActive(LifecycleEventArgs $args) : void
{
$entity = $args->getObject();
- if (!$entity instanceof UniqueActiveInterface) {
+ if (!false) {
return;
}
if (!$entity->isActive()) {
|
|
run / Mutation Tests (8.2):
src/Manager/ORM/BaseQueryTrait.php#L28
Escaped Mutant for Mutator "Foreach_":
--- Original
+++ New
@@ @@
*/
protected final function addOrder(QueryBuilder $builder, array $sort, string $defaultAlias, array $aliasMapping = [], string $defaultOrder = 'asc') : QueryBuilder
{
- foreach ($sort as $field => $order) {
+ foreach (array() as $field => $order) {
if (\is_int($field)) {
$field = $order;
$order = $defaultOrder;
|