feat(ferveo): derive eq in DkgPublicKey

nucypher · Oct 31, 2023 · 52efe01 · 52efe01
1 parent 13d9d26
commit 52efe01
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 13 deletions.
diff --git a/ferveo-common/src/keypair.rs b/ferveo-common/src/keypair.rs
@@ -61,15 +61,7 @@ impl<E: Pairing> PublicKey<E> {
 
 impl<E: Pairing> PartialOrd for PublicKey<E> {
     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
-        if self.encryption_key.x() == other.encryption_key.x() {
-            return self
-                .encryption_key
-                .y()
-                .partial_cmp(&other.encryption_key.y());
-        }
-        self.encryption_key
-            .x()
-            .partial_cmp(&other.encryption_key.x())
+        Some(self.cmp(other))
     }
 }
 
@@ -102,7 +94,7 @@ pub struct Keypair<E: Pairing> {
 
 impl<E: Pairing> PartialOrd for Keypair<E> {
     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
-        self.decryption_key.partial_cmp(&other.decryption_key)
+        Some(self.cmp(other))
     }
 }
 

diff --git a/ferveo/src/api.rs b/ferveo/src/api.rs
@@ -139,7 +139,7 @@ impl From<bindings_wasm::FerveoVariant> for FerveoVariant {
 }
 
 #[serde_as]
-#[derive(Copy, Clone, Debug, PartialEq, Serialize, Deserialize)]
+#[derive(Copy, Clone, Debug, Eq, PartialEq, Serialize, Deserialize)]
 pub struct DkgPublicKey(
     #[serde_as(as = "serialization::SerdeAs")] pub(crate) G1Affine,
 );

diff --git a/ferveo/src/dkg.rs b/ferveo/src/dkg.rs
@@ -28,7 +28,7 @@ pub struct DkgValidator<E: Pairing> {
 
 impl<E: Pairing> PartialOrd for DkgValidator<E> {
     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
-        self.share_index.partial_cmp(&other.share_index)
+        Some(self.cmp(other))
     }
 }
 

diff --git a/ferveo/src/validator.rs b/ferveo/src/validator.rs
@@ -49,7 +49,7 @@ pub struct Validator<E: Pairing> {
 
 impl<E: Pairing> PartialOrd for Validator<E> {
     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
-        self.address.partial_cmp(&other.address)
+        Some(self.cmp(other))
     }
 }