Point out that aggregate coefficients need to be updated too

nucypher · May 21, 2024 · 9ffb75c · 9ffb75c
1 parent 2f92a37
commit 9ffb75c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/ferveo/src/lib.rs b/ferveo/src/lib.rs
@@ -685,7 +685,9 @@ mod test_dkg_full {
             .refresh(&update_transcripts, &validator_map)
             .unwrap();
 
-        // TODO: Assert new aggregate is different than original
+        // TODO: Assert new aggregate is different than original, including coefficients
+        assert_ne!(local_aggregate.aggregate, new_aggregate);
+
         // TODO: Show that all participants obtain the same new aggregate transcript.
 
         // Get decryption shares, now with the refreshed aggregate transcript:

diff --git a/ferveo/src/pvss.rs b/ferveo/src/pvss.rs
@@ -417,7 +417,7 @@ impl<E: Pairing, T: Aggregate> PubliclyVerifiableSS<E, T> {
             .collect();
 
         let refresed_aggregate_transcript = Self {
-            coeffs: self.coeffs.clone(),
+            coeffs: self.coeffs.clone(),  // FIXME: coeffs need to be updated too
             shares: updated_blinded_shares,
             sigma: self.sigma,
             phantom: Default::default(),