Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose FerveoVariant from bindings #137

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Expose FerveoVariant from bindings #137

merged 1 commit into from
Jul 5, 2023

Conversation

piotr-roslaniec
Copy link

@piotr-roslaniec piotr-roslaniec commented Jul 3, 2023 •
edited
Loading

Type of PR:

  • Feature

Required reviews:

  • 2

What this does:

  • Exposes FerveoVariant in Python and WASM bindings

Issues fixed/closed:

Why it's needed:

  • Simplifies handling of different Ferveo variants by exposing a shared type

Notes for reviewers:

@piotr-roslaniec piotr-roslaniec force-pushed the ferveo-variant branch 2 times, most recently from ac9db54 to 4f81ea9 Compare July 4, 2023 08:16
@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review July 4, 2023 08:26
@piotr-roslaniec piotr-roslaniec mentioned this pull request Jul 4, 2023
Merged
derekpierre
derekpierre approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸 nice work.

Just curious, are there any downstream nucypher changes based on this?

This was referenced Jul 4, 2023
Closed
Closed
@piotr-roslaniec
Copy link
Author

@derekpierre I added relevant downstream issues to PR description

@piotr-roslaniec piotr-roslaniec merged commit 802ddba into pk-static-bytes Jul 5, 2023
9 checks passed
@piotr-roslaniec piotr-roslaniec deleted the ferveo-variant branch July 5, 2023 14:02
@piotr-roslaniec piotr-roslaniec restored the ferveo-variant branch July 5, 2023 14:02
@piotr-roslaniec piotr-roslaniec mentioned this pull request Aug 1, 2023
Closed
@piotr-roslaniec piotr-roslaniec deleted the ferveo-variant branch August 14, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theref theref theref approved these changes

@derekpierre derekpierre derekpierre approved these changes

@KPrasch KPrasch Awaiting requested review from KPrasch

@manumonti manumonti Awaiting requested review from manumonti

Assignees
No one assigned
Labels
None yet
Projects
v7.0.0 (TACo)
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotr-roslaniec @theref @derekpierre