Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking release - ferveo-pre-release@0.1.0-alpha.11 #138

Merged
merged 23 commits into from
Jul 10, 2023
Merged

Conversation

piotr-roslaniec
Copy link

@piotr-roslaniec piotr-roslaniec commented Jul 5, 2023

Type of PR:

  • Other

Required reviews:

  • 1

What this does:

High-level idea of the changes introduced in this PR.
List relevant API changes (if any), as well as related PRs and issues.

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023

Codecov Report

Merging #138 (ffb9b21) into main (c259bf7) will decrease coverage by 0.53%.
The diff coverage is 71.09%.

@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   79.00%   78.48%   -0.53%     
==========================================
  Files          24       24              
  Lines        4872     4954      +82     
==========================================
+ Hits         3849     3888      +39     
- Misses       1023     1066      +43     
Impacted Files Coverage Δ
ferveo-common/src/lib.rs 6.66% <0.00%> (-93.34%) ⬇️
ferveo/src/bindings_wasm.rs 0.00% <0.00%> (ø)
ferveo/src/utils.rs 93.75% <ø> (-0.99%) ⬇️
subproductdomain/src/lib.rs 75.07% <0.00%> (ø)
tpke/src/decryption.rs 69.92% <ø> (ø)
ferveo-common/src/keypair.rs 72.43% <8.33%> (-2.40%) ⬇️
ferveo/src/bindings_python.rs 53.44% <28.76%> (-2.09%) ⬇️
ferveo/src/api.rs 91.03% <91.59%> (+0.57%) ⬆️
ferveo/src/dkg.rs 96.11% <100.00%> (+0.62%) ⬆️
ferveo/src/lib.rs 97.44% <100.00%> (+0.03%) ⬆️
... and 3 more

@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review July 7, 2023 07:32
Copy link
Member

@manumonti manumonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@piotr-roslaniec piotr-roslaniec merged commit 434fd5d into main Jul 10, 2023
9 checks passed
@piotr-roslaniec piotr-roslaniec deleted the development branch July 10, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants