Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the fast variant #187

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Remove the fast variant #187

merged 1 commit into from
Mar 19, 2024

Conversation

piotr-roslaniec
Copy link

@piotr-roslaniec piotr-roslaniec commented Mar 13, 2024 •
edited
Loading

Type of PR:

  • Feature

Required reviews:

  • 1

Issues fixed:

What this does:

  • Removes the fast variant from Ferveo

Why it's needed:

  • We don't plan on using the fast variant, only the simple and the precomputed variant

Notes for reviewers:

  • Based on main, merge at will

@piotr-roslaniec piotr-roslaniec force-pushed the remove-fast-variant branch 2 times, most recently from 8b8cdec to 9fa869e Compare March 13, 2024 09:41
@piotr-roslaniec piotr-roslaniec changed the base branch from main to rocknroll March 19, 2024 09:44
@piotr-roslaniec piotr-roslaniec merged commit b72a338 into nucypher:rocknroll Mar 19, 2024
11 checks passed
@piotr-roslaniec piotr-roslaniec deleted the remove-fast-variant branch March 19, 2024 13:19
@piotr-roslaniec piotr-roslaniec mentioned this pull request Mar 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cygnusv cygnusv Awaiting requested review from cygnusv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate fast tDec variant from tpke with ferveo crate
1 participant
@piotr-roslaniec