-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACP/ThresholdMessageKit Work #74
Merged
Merged
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
30aab6c
Initial code and tests for AccessControlPolicy and its use by Thresho…
derekpierre 2af5242
Initial code for ThresholdMessageKit and tests.
derekpierre 3bab4c3
Add aad() function to AccessControlPolicy.
derekpierre 07b4339
Rename ThresholdMessageKit kem/dem ciphertext to header and payload r…
derekpierre 32cc6c8
Rename ThresholdMessageKit underlying member for the access control p…
derekpierre da87ad0
Add AccessControlPolicy and ThresholdMessageKit to `nucypher_core` py…
derekpierre a5cfd82
Update nucypher-core to incorporate latest changes from ferveo regard…
derekpierre 71312cf
Modify AccessControlPolicy to be instantiated with an AuthenticatedDa…
derekpierre 1136efe
Add encrypt_for_dkg function so that Ciphertext and AuthenticatedData…
derekpierre 5ed307f
Make ThresholdMessageKit more efficient by not returning the Cipherte…
derekpierre 2ba7f5d
Update `nucypher-core` changelog with latest changes.
derekpierre 89031a0
Fix mypy build error. Related to this https://pyo3.rs/main/function/s…
derekpierre 54d155a
Use to_bytes macro for dkg wasm bindings.
derekpierre ef2568d
Use equals from DkgPublicKey directly for AuthenticatedData equals.
derekpierre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derekpierre I just recalled your comment on
Optional<&Condition>
in DKG structures. Are conditions supposed to be optional here? Or is it just downstream of that optionality in the DKG structures?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is downstream.
This is something that came to me last night, but it pervades many types in
nucypher-core
(ThresholdDecryptionRequest, ... etc.) and I didn't have time to fix it across all of them. I think we should fix it in a separate PR. Basically for DKG types Conditions should not be Optional but should be specified. Hence I filed #76 .