Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python typing stubs #84

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Fix Python typing stubs #84

merged 1 commit into from
Sep 27, 2023

Conversation

fjarri
Copy link
Contributor

@fjarri fjarri commented Sep 27, 2023

Type of PR:

  • Bugfix

Required reviews:

  • 1

What this does:
Fixes some incorrect Python typing stubs:

  • ThresholdMessageKit.decrypt_with_shared_secret() - added a missing bytes return type
  • combine_decryption_shares_simple() - replaced the incorrect bytes return type with SharedSecret

@codecov-commenter
Copy link

Codecov Report

Merging #84 (4db69c8) into main (d49e98a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   23.45%   23.45%           
=======================================
  Files          18       18           
  Lines        3521     3521           
=======================================
  Hits          826      826           
  Misses       2695     2695           

@KPrasch KPrasch merged commit 0e6a89d into nucypher:main Sep 27, 2023
10 checks passed
@piotr-roslaniec
Copy link
Contributor

Copying ferveo changes here: nucypher/ferveo#165

@derekpierre derekpierre mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants