Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to nucypher-core@0.12.0 #273

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Update to nucypher-core@0.12.0 #273

merged 2 commits into from
Aug 28, 2023

Conversation

piotr-roslaniec
Copy link
Contributor

@piotr-roslaniec piotr-roslaniec commented Aug 24, 2023 •
edited
Loading

Type of PR:

  • Feature

Required reviews:

  • 1

What this does:

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

  • Requires @nucypher/nucypher-core@0.12.0 to be released on npm to merge this PR
  • Tests are failing in result of a missing nucypher-core version

@piotr-roslaniec piotr-roslaniec changed the base branch from main to alpha August 24, 2023 13:30
@piotr-roslaniec piotr-roslaniec added the do not merge Open for review but do not merge please label Aug 24, 2023
@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review August 24, 2023 13:32
@piotr-roslaniec piotr-roslaniec mentioned this pull request Aug 24, 2023
Merged
7 tasks
@piotr-roslaniec piotr-roslaniec mentioned this pull request Aug 24, 2023
Merged
manumonti
manumonti approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@manumonti manumonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✌️

package.json Outdated
@@ -52,7 +52,7 @@
"prebuild": "yarn typechain"
},
"dependencies": {
"@nucypher/nucypher-core": "^0.11.0",
"@nucypher/nucypher-core": "file:../nucypher-core/nucypher-core-wasm/pkg",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this line will be changed when nucypher/nucypher-core#77 is merged, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but specifically when we release @nucypher/nucypher-core@0.12.0 on npm.

@github-actions
Copy link

Bundled size for the package is listed below:

build/main/src/characters: 74.22 KB
build/main/src/kits: 19.53 KB
build/main/src/conditions/context: 42.97 KB
build/main/src/conditions/predefined: 19.53 KB
build/main/src/conditions/base: 54.69 KB
build/main/src/conditions: 156.25 KB
build/main/src/agents: 39.06 KB
build/main/src/sdk/strategy: 35.16 KB
build/main/src/sdk: 46.88 KB
build/main/src/policies: 19.53 KB
build/main/src: 433.59 KB
build/main/types/ethers-contracts/factories: 82.03 KB
build/main/types/ethers-contracts: 152.34 KB
build/main/types: 156.25 KB
build/main: 644.53 KB
build/module/src/characters: 74.22 KB
build/module/src/kits: 19.53 KB
build/module/src/conditions/context: 42.97 KB
build/module/src/conditions/predefined: 19.53 KB
build/module/src/conditions/base: 54.69 KB
build/module/src/conditions: 156.25 KB
build/module/src/agents: 39.06 KB
build/module/src/sdk/strategy: 31.25 KB
build/module/src/sdk: 42.97 KB
build/module/src/policies: 19.53 KB
build/module/src: 425.78 KB
build/module/types/ethers-contracts/factories: 82.03 KB
build/module/types/ethers-contracts: 152.34 KB
build/module/types: 156.25 KB
build/module: 636.72 KB
build: 1.26 MB

@piotr-roslaniec piotr-roslaniec merged commit b7161fd into alpha Aug 28, 2023
12 checks passed
@piotr-roslaniec piotr-roslaniec deleted the nucypher-core-0.12.0 branch August 28, 2023 15:25
derekpierre
derekpierre reviewed Aug 29, 2023
View reviewed changes
src/characters/cbd-recipient.ts
@@ -48,10 +49,13 @@ export class ThresholdDecrypter {
conditionExpr: ConditionExpression,
ciphertext: Ciphertext
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this instead be ThresholdMessageKit and not Ciphertext...?

src/characters/cbd-recipient.ts
Comment on lines +93 to +94
ciphertext: Ciphertext,
acp: AccessControlPolicy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piotr-roslaniec Should this just be ThreshodlMessageKit? It has the ciphertext and the acp in it...?

@piotr-roslaniec
Copy link
Contributor Author

@derekpierre I will fix those in a follow-up PR.

piotr-roslaniec added a commit that referenced this pull request Aug 30, 2023
@piotr-roslaniec
apply pr suggestions for #273
2c3b18b
@piotr-roslaniec piotr-roslaniec mentioned this pull request Aug 30, 2023
Merged
piotr-roslaniec added a commit that referenced this pull request Aug 30, 2023
@piotr-roslaniec
apply pr suggestions for #273
e46a6a6
piotr-roslaniec added a commit that referenced this pull request Sep 3, 2023
@piotr-roslaniec
apply pr suggestions for #273
aad5942
piotr-roslaniec added a commit that referenced this pull request Sep 4, 2023
@piotr-roslaniec
apply pr suggestions for #273
f1f729b
piotr-roslaniec added a commit that referenced this pull request Sep 5, 2023
@piotr-roslaniec
apply pr suggestions for #273
cb258e4
piotr-roslaniec added a commit that referenced this pull request Sep 8, 2023
@piotr-roslaniec
Apply PR suggestions for #273 (#286)
c18f996
@derekpierre derekpierre mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekpierre derekpierre derekpierre left review comments

@manumonti manumonti manumonti approved these changes

@jMyles jMyles Awaiting requested review from jMyles

@KPrasch KPrasch Awaiting requested review from KPrasch

@cygnusv cygnusv Awaiting requested review from cygnusv

@theref theref Awaiting requested review from theref

Assignees
No one assigned
Labels
do not merge Open for review but do not merge please
Projects
v7.0.0 (TACo)
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotr-roslaniec @derekpierre @manumonti