From e6ba185def39ca9b292cac39518adea7c88db76f Mon Sep 17 00:00:00 2001 From: Vigith Maurice Date: Sun, 24 Mar 2024 08:32:42 -0700 Subject: [PATCH] chore: code review Signed-off-by: Vigith Maurice --- examples/source-transformer-now/Dockerfile | 4 ++-- src/sourcetransform.rs | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/examples/source-transformer-now/Dockerfile b/examples/source-transformer-now/Dockerfile index 5bc8583..2d364ff 100644 --- a/examples/source-transformer-now/Dockerfile +++ b/examples/source-transformer-now/Dockerfile @@ -1,4 +1,4 @@ -FROM rust:1.70 as build +FROM rust:1.75-bookworm as build RUN apt-get update RUN apt-get install protobuf-compiler -y @@ -16,7 +16,7 @@ COPY ./Cargo.lock ./Cargo.lock RUN cargo build --release # our final base -FROM rust +FROM debian:bookworm # copy the build artifact from the build stage COPY --from=build /examples/target/release/server . diff --git a/src/sourcetransform.rs b/src/sourcetransform.rs index a9cbdcc..48a432f 100644 --- a/src/sourcetransform.rs +++ b/src/sourcetransform.rs @@ -18,7 +18,7 @@ struct SourceTransformerService { #[async_trait] pub trait SourceTransformer { /// transform takes in an input element and can produce 0, 1, or more results. The input is a [`SourceTransformRequest`] - /// and the output is a ['Vec`] of [`Message`]. In a `transform` each element is processed independently + /// and the output is a [`Vec`] of [`Message`]. In a `transform` each element is processed independently /// and there is no state associated with the elements. Source transformer can be used for transforming /// and assigning event time to input messages. More about source transformer can be read /// [here](https://numaflow.numaproj.io/user-guide/sources/transformer/overview/) @@ -123,7 +123,7 @@ where Ok(Response::new(proto::SourceTransformResponse { results: messages .into_iter() - .map(move |msg| msg.into()) + .map(|msg| msg.into()) .collect::>(), })) } @@ -139,7 +139,7 @@ pub struct Server { sock_addr: PathBuf, max_message_size: usize, server_info_file: PathBuf, - sourcetrf_svc: Option, + svc: Option, } impl Server { @@ -153,7 +153,7 @@ impl Server { sock_addr: "/var/run/numaflow/sourcetransform.sock".into(), max_message_size: 64 * 1024 * 1024, server_info_file: server_info_file.into(), - sourcetrf_svc: Some(sourcetransformer_svc), + svc: Some(sourcetransformer_svc), } } @@ -200,7 +200,7 @@ impl Server { T: SourceTransformer + Send + Sync + 'static, { let listener = shared::create_listener_stream(&self.sock_addr, &self.server_info_file)?; - let handler = self.sourcetrf_svc.take().unwrap(); + let handler = self.svc.take().unwrap(); let sourcetrf_svc = SourceTransformerService { handler }; let sourcetrf_svc = proto::source_transform_server::SourceTransformServer::new(sourcetrf_svc)