Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the input to
map
function from a trait to a concrete struct type. Many of the common Rust server crates seems to use a concrete struct to represent the request eg. hyper, axum, actix_web. As of now, theread
function in thesource::Sourcer
also accepts a struct as input.If the current API (i.e, the
MapRequest
struct) needs changes in future, most likely we will be able to abstract that with generics and making the struct fields private.I directly created the PR since the effort needed for explaining it in an issue would be almost same as implementing the code. If needed, I will revert back to using trait.