Remove Datum trait in mapper #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
BulkBeing
commented
Jan 8, 2024
| pub async fn start_uds_server<T>(m: T) -> Result<(), Box<dyn std::error::Error>> | ||
| where | ||
| T: Sourcer + Send + Sync + 'static, | ||
| T: Sourcer + Clone + Send + Sync + 'static, |
There was a problem hiding this comment.
Allows Arc<Sourcer> to be created at user's side and reusing the same. Reduces one possible heap allocation if user also has to create an Arc<Sourcer>.
|
Could you please add why you want to remove that trait in the description? The reason it was added was to abstract the data type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the input to
mapfunction from a trait to a concrete struct type. Many of the common Rust server crates seems to use a concrete struct to represent the request eg. hyper, axum, actix_web. As of now, thereadfunction in thesource::Sourceralso accepts a struct as input.If the current API (i.e, the
MapRequeststruct) needs changes in future, most likely we will be able to abstract that with generics and making the struct fields private.I directly created the PR since the effort needed for explaining it in an issue would be almost same as implementing the code. If needed, I will revert back to using trait.