chore: Incorporate Proto Definition Changes For Reduce #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
vigith
reviewed
Jun 25, 2024
src/error.rs
Outdated
There was a problem hiding this comment.
thiserror will make life much easier here
| let map_svc = MapService { handler }; | ||
|
|
||
| // Create a channel to send shutdown signal to the server to do graceful shutdown in case of non retryable errors. | ||
| let (internal_shutdown_tx, internal_shutdown_rx) = mpsc::channel(1); |
There was a problem hiding this comment.
We need to store that as a variable inside the ReduceService struct for it to be used inside the reduce_fn function. Since oneshot is not cloneable, I had to opt for the mpsc method.
| use tracing::info; | ||
|
|
||
| // #[tracing::instrument(skip(path), fields(path = ?path.as_ref()))] | ||
| #[tracing::instrument(fields(path = ?path.as_ref()))] | ||
| #[tracing::instrument(fields(path = ? path.as_ref()))] |
There was a problem hiding this comment.
Suggested change
| #[tracing::instrument(fields(path = ? path.as_ref()))] | |
| #[tracing::instrument(fields(path = ?path.as_ref()))] |
src/shared.rs
Outdated
Comment on lines
78
to
86
| let custom1 = async { | ||
| internal_rx.recv().await; | ||
| }; | ||
|
|
||
| let custom2 = async { | ||
| if let Some(rx) = user_rx { | ||
| rx.await.ok(); | ||
| } | ||
| }; |
src/shared.rs
Outdated
Comment on lines
163
to
166
| assert!(contents.contains("\"language\":\"rust\"")); | ||
| assert!(contents.contains("\"version\":\"0.0.1\"")); | ||
| assert!(contents.contains("\"metadata\":{}")); |
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
vigith
reviewed
Jun 27, 2024
src/sourcetransform.rs
Outdated
Comment on lines
340
to
344
| .await?; | ||
|
|
||
| // cleanup the socket file after the server is shutdown | ||
| // UnixListener doesn't implement Drop trait, so we have to manually remove the socket file | ||
| let _ = fs::remove_file(&self.sock_addr); |
There was a problem hiding this comment.
we will not remove the file if we short-circuit using ?
There was a problem hiding this comment.
Thanks for catching this, totally missed that case.
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com>
|
I will create a follow-up PR to review error handling in services, excluding 'reduce'. Currently, if the user code has a panic, it is not being propagated back in 'map'. |
vigith
approved these changes
Jun 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #46