Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: retrieve sdk version from env #83

Merged
merged 4 commits into from
Sep 9, 2024
Merged

chore: retrieve sdk version from env #83

merged 4 commits into from
Sep 9, 2024

Conversation

KeranYang
Copy link
Member

@KeranYang KeranYang commented Sep 9, 2024

Testing

Manually changed the numaflow platform MINIMUM_SUPPORTED_SDK_VERSIONS to ask for minimum rust version 0.0.2. Ran a monovertex and verified getting.

2024-09-08T20:08:56.033906Z  INFO monovertex::server_info: Server info file: ServerInfo { protocol: "uds", language: "rust", minimum_numaflow_version: "1.3.1", version: "0.0.1", metadata: Some({}) }
2024-09-08T20:08:56.034003Z  INFO monovertex::server_info: Version_info: VersionInfo { version: "latest+unknown", build_date: "1970-01-01T00:00:00Z", git_commit: "", git_tag: "", git_tree_state: "", go_version: "unknown", compiler: "", platform: "linux/aarch64" }
2024-09-08T20:08:56.034069Z  WARN monovertex: Error waiting for source server info file: ServerInfoError("SDK version 0.0.1 must be upgraded to at least 0.0.2, in order to work with the current numaflow version")
2024-09-08T20:08:56.034079Z ERROR monovertex: Application error: ForwarderError("Error waiting for server info file")
2024-09-08T20:08:56.034188Z  INFO monovertex: Gracefully Exiting...

Made this change, reran the monovertex, the error was gone.

Also used a unit test to verify the value of env!("CARGO_PKG_VERSION") is 0.1.1.

Signed-off-by: Keran Yang <yangkr920208@gmail.com>
.
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
@KeranYang KeranYang marked this pull request as ready for review September 9, 2024 15:10
@yhl25 yhl25 merged commit d3afabd into numaproj:main Sep 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants