feat: Bidirectional streaming for source transformer #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
This was referenced Sep 26, 2024
vigith
reviewed
Sep 27, 2024
|
|
||
| const DEFAULT_MAX_MESSAGE_SIZE: usize = 64 * 1024 * 1024; | ||
| const DEFAULT_SOCK_ADDR: &str = "/var/run/numaflow/sourcetransform.sock"; | ||
| const DEFAULT_SERVER_INFO_FILE: &str = "/var/run/numaflow/sourcetransformer-server-info"; | ||
| const DEFAULT_CHANNEL_SIZE: usize = 1000; | ||
|
|
||
| const DROP: &str = "U+005C__DROP__"; | ||
|
|
There was a problem hiding this comment.
pub mod proto rename proto to sourcetransformer_pb ?
There was a problem hiding this comment.
I don't think that is needed since the it's absolute name (crate::sourcetransform::proto) already makes the namespacing clear.
There was a problem hiding this comment.
@yhl25 had some opinions on this.
src/sourcetransform.rs
Outdated
| return Err(Status::invalid_argument("Handshake not present")); | ||
| } | ||
|
|
||
| let handle: JoinHandle<Result<(), Error>> = tokio::spawn({ |
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
yhl25
reviewed
Sep 30, 2024
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
yhl25
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of numaproj/numaflow#2046
Related PRs:
numaproj/numaflow-go#147
numaproj/numaflow#2071