fix: global variable call

Signed-off-by: Kushal Batra <i.kushalbatra@gmail.com>
numaproj · Jun 13, 2024 · 39069f1 · 39069f1
1 parent bf77eab
commit 39069f1
Show file tree

Hide file tree

Showing 13 changed files with 672 additions and 174 deletions.
diff --git a/numalogic/udfs/__main__.py b/numalogic/udfs/__main__.py
@@ -19,7 +19,7 @@
 BASE_CONF_FILE_PATH: Final[str] = os.getenv("BASE_CONF_PATH", default=DEFAULT_BASE_CONF_PATH)
 APP_CONF_FILE_PATH: Final[str] = os.getenv("APP_CONF_PATH", default=DEFAULT_APP_CONF_PATH)
 METRICS_PORT: Final[int] = int(os.getenv("METRICS_PORT", default=DEFAULT_METRICS_PORT))
-METRICS_ENABLED: Final[bool] = bool(os.getenv("METRICS_ENABLED", default="True"))
+METRICS_ENABLED: Final[bool] = bool(int(os.getenv("METRICS_ENABLED", default="1")))
 METRICS_CONF_PATH: Final[str] = os.getenv("METRICS_CONF_PATH", default=DEFAULT_METRICS_CONF_PATH)
 
 

diff --git a/numalogic/udfs/inference.py b/numalogic/udfs/inference.py
@@ -31,7 +31,7 @@
 LOCAL_CACHE_TTL = int(os.getenv("LOCAL_CACHE_TTL", "3600"))
 LOCAL_CACHE_SIZE = int(os.getenv("LOCAL_CACHE_SIZE", "10000"))
 LOAD_LATEST = os.getenv("LOAD_LATEST", "false").lower() == "true"
-METRICS_ENABLED = os.getenv("METRICS_ENABLED", "True").lower() == "true"
+METRICS_ENABLED = bool(int(os.getenv("METRICS_ENABLED", default="1")))
 
 
 class InferenceUDF(NumalogicUDF):

diff --git a/numalogic/udfs/payloadtx.py b/numalogic/udfs/payloadtx.py
@@ -12,7 +12,7 @@
 from numalogic.udfs._logger import configure_logger, log_data_payload_values
 from numalogic.udfs._metrics_utility import _increment_counter
 
-METRICS_ENABLED = os.getenv("METRICS_ENABLED", "True").lower() == "true"
+METRICS_ENABLED = bool(int(os.getenv("METRICS_ENABLED", default="1")))
 
 _struct_log = configure_logger()
 

diff --git a/numalogic/udfs/postprocess.py b/numalogic/udfs/postprocess.py
@@ -30,7 +30,7 @@
 LOCAL_CACHE_TTL = int(os.getenv("LOCAL_CACHE_TTL", "3600"))
 LOCAL_CACHE_SIZE = int(os.getenv("LOCAL_CACHE_SIZE", "10000"))
 LOAD_LATEST = os.getenv("LOAD_LATEST", "false").lower() == "true"
-METRICS_ENABLED = os.getenv("METRICS_ENABLED", "True").lower() == "true"
+METRICS_ENABLED = bool(int(os.getenv("METRICS_ENABLED", default="1")))
 SCORE_PREFIX = os.getenv("SCORE_PREFIX", "unified")
 
 _struct_log = configure_logger()

diff --git a/numalogic/udfs/preprocess.py b/numalogic/udfs/preprocess.py
@@ -31,8 +31,7 @@
 LOCAL_CACHE_TTL = int(os.getenv("LOCAL_CACHE_TTL", "3600"))
 LOCAL_CACHE_SIZE = int(os.getenv("LOCAL_CACHE_SIZE", "10000"))
 LOAD_LATEST = os.getenv("LOAD_LATEST", "false").lower() == "true"
-METRICS_ENABLED = os.getenv("METRICS_ENABLED", "True").lower() == "true"
-
+METRICS_ENABLED = bool(int(os.getenv("METRICS_ENABLED", default="1")))
 _struct_log = configure_logger()
 
 

diff --git a/numalogic/udfs/staticthresh.py b/numalogic/udfs/staticthresh.py
@@ -13,7 +13,7 @@
 from numalogic.udfs._metrics_utility import _increment_counter
 from numalogic.udfs.entities import StreamPayload, OutputPayload
 
-METRICS_ENABLED = os.getenv("METRICS_ENABLED", "True").lower() == "true"
+METRICS_ENABLED = bool(int(os.getenv("METRICS_ENABLED", default="1")))
 SCORE_PREFIX = os.getenv("SCORE_PREFIX", "unified")
 _struct_log = configure_logger()
 

diff --git a/numalogic/udfs/tools.py b/numalogic/udfs/tools.py
@@ -17,7 +17,7 @@
 from numalogic.udfs._metrics_utility import _set_gauge, _increment_counter, _add_info
 from numalogic.udfs.entities import StreamPayload, TrainerPayload
 
-METRICS_ENABLED = os.getenv("METRICS_ENABLED", "True").lower() == "true"
+METRICS_ENABLED = bool(int(os.getenv("METRICS_ENABLED", default="1")))
 
 
 _struct_log = configure_logger()

diff --git a/numalogic/udfs/trainer/_base.py b/numalogic/udfs/trainer/_base.py
@@ -25,8 +25,7 @@
 from numalogic.udfs.tools import TrainMsgDeduplicator
 import torch
 
-METRICS_ENABLED = os.getenv("METRICS_ENABLED", "True").lower() == "true"
-
+METRICS_ENABLED = bool(int(os.getenv("METRICS_ENABLED", default="1")))
 _struct_log = configure_logger()
 
 

diff --git a/numalogic/udfs/trainer/_druid.py b/numalogic/udfs/trainer/_druid.py
@@ -14,8 +14,7 @@
 from numalogic.udfs.trainer._base import TrainerUDF
 from numalogic.udfs._metrics_utility import _increment_counter, _add_summary
 
-METRICS_ENABLED = os.getenv("METRICS_ENABLED", "True").lower() == "true"
-
+METRICS_ENABLED = bool(int(os.getenv("METRICS_ENABLED", default="1")))
 _struct_log = configure_logger()
 
 

diff --git a/numalogic/udfs/trainer/_prom.py b/numalogic/udfs/trainer/_prom.py
@@ -15,8 +15,7 @@
 from numalogic.udfs._metrics_utility import _increment_counter, _add_summary
 from numalogic.udfs.trainer._base import TrainerUDF
 
-METRICS_ENABLED = os.getenv("METRICS_ENABLED", "True").lower() == "true"
-
+METRICS_ENABLED = bool(int(os.getenv("METRICS_ENABLED", default="1")))
 _struct_log = configure_logger()
 
 

diff --git a/numalogic/udfs/trainer/_rds.py b/numalogic/udfs/trainer/_rds.py
@@ -15,8 +15,7 @@
 from datetime import datetime, timedelta
 import pytz
 
-METRICS_ENABLED = os.getenv("METRICS_ENABLED", "True").lower() == "true"
-
+METRICS_ENABLED = bool(int(os.getenv("METRICS_ENABLED", default="1")))
 _LOGGER = logging.getLogger(__name__)