Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tensor dimension swap instead of view change #240

Merged
merged 5 commits into from
Aug 15, 2023
Merged

fix: tensor dimension swap instead of view change #240

merged 5 commits into from
Aug 15, 2023

Conversation

ab93
Copy link
Member

@ab93 ab93 commented Aug 10, 2023

No description provided.

Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 self-assigned this Aug 10, 2023
@ab93 ab93 added bug Something isn't working area/ml Machine Learning based changes labels Aug 10, 2023
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #240 (ac4dfac) into main (2dfd84c) will increase coverage by 0.13%.
The diff coverage is 95.00%.

@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   96.30%   96.43%   +0.13%     
==========================================
  Files          53       53              
  Lines        2221     2219       -2     
  Branches      173      174       +1     
==========================================
+ Hits         2139     2140       +1     
+ Misses         58       56       -2     
+ Partials       24       23       -1     
Files Changed Coverage Δ
numalogic/models/autoencoder/base.py 98.30% <50.00%> (ø)
numalogic/models/autoencoder/variants/conv.py 100.00% <100.00%> (ø)
numalogic/models/autoencoder/variants/vanilla.py 100.00% <100.00%> (ø)
numalogic/models/vae/variants/conv.py 100.00% <100.00%> (ø)
numalogic/tools/data.py 95.65% <100.00%> (+0.24%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 marked this pull request as ready for review August 11, 2023 17:36
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Copy link
Contributor

@s0nicboOm s0nicboOm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 enabled auto-merge (squash) August 15, 2023 17:41
@ab93 ab93 merged commit 76cac48 into main Aug 15, 2023
10 checks passed
@ab93 ab93 deleted the datashape branch August 15, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ml Machine Learning based changes bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants