Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve serialization performance #243

Merged
merged 3 commits into from
Aug 16, 2023
Merged

perf: improve serialization performance #243

merged 3 commits into from
Aug 16, 2023

Conversation

ab93
Copy link
Member

@ab93 ab93 commented Aug 16, 2023

  • close the buffer
  • use highest pickle protocol by default
  • benchmarking in unit tests
Change Improvement
Closing buffer 3.2%
Protocol update 15.5%

Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 self-assigned this Aug 16, 2023
@ab93 ab93 added the area/performance Performance related improvements label Aug 16, 2023
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 marked this pull request as ready for review August 16, 2023 18:35
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #243 (81d9669) into main (7ef40a0) will decrease coverage by 0.26%.
The diff coverage is 100.00%.

❗ Current head 81d9669 differs from pull request most recent head 4306978. Consider uploading reports for the commit 4306978 to get more accurate results

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
- Coverage   96.43%   96.18%   -0.26%     
==========================================
  Files          53       53              
  Lines        2219     2226       +7     
  Branches      174      174              
==========================================
+ Hits         2140     2141       +1     
- Misses         56       60       +4     
- Partials       23       25       +2     
Files Changed Coverage Δ
numalogic/registry/_serialize.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@s0nicboOm s0nicboOm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 enabled auto-merge (squash) August 16, 2023 19:26
@ab93 ab93 merged commit 8482c01 into main Aug 16, 2023
8 checks passed
@ab93 ab93 deleted the improve-serialization branch August 16, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance Performance related improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants