Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: numalogic udfs #271

Merged
merged 29 commits into from
Aug 31, 2023
Merged

feat!: numalogic udfs #271

merged 29 commits into from
Aug 31, 2023

Conversation

ab93
Copy link
Member

@ab93 ab93 commented Aug 29, 2023 •
edited
Loading

  • add numalogic udf module
  • preproc, inference, postproc and trainer udfs
  • config updates and factory classes
  • dockerfile
  • image release github action

ab93 and others added 18 commits August 28, 2023 20:32
@ab93
fix: tensor dimension swap instead of view change
61a5859 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
revert transformer changes
de813aa 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
rename udf module
d6f7a63 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
fix: typo
ef738b5 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
add entities
e25c755 
Signed-off-by: Avik Basu <avik_basu@intuit.com>
@ab93
add inference udf
34018aa 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
typo fix
a8fce7f 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
add tests for inference
fbba76e 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
add stream conf (#251)
41d3458 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@s0nicboOm @ab93
feat: add preproc changes (#250)
a860b75 
Preprocess udf

---------
Signed-off-by: Kushal Batra <34571348+s0nicboOm@users.noreply.github.com>
@ab93
feat: add trainer udf (#257)
d3b1fbd 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@s0nicboOm @ab93
feat: add postproc and threshold as PostProcessUDF (#256)
198da3b 
Add PostProc

---------

Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@ab93
feat: add dockerfile (#258)
9b90116 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@s0nicboOm @ab93
fix: get config from constructor (#259)
7b2baa4 
Get config from constructor for Preproc and Postproc

Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: Kushal Batra <34571348+s0nicboOm@users.noreply.github.com>
@ab93
fix: trainer conf (#260)
a5feecc 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
feat: load config from conf map (#268)
ab9288b 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
fix: trainer udf tests
b17af23 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@s0nicboOm
fix: add publisher (#272)
181a2c0 
1. Add publisher
2. Add test cases for preproc and postproc

Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@ab93 ab93 self-assigned this Aug 29, 2023
@ab93 ab93 added the enhancement New feature or request label Aug 29, 2023
@ab93
fix test errors
dbb834c 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Aug 29, 2023 •
edited
Loading

Codecov Report

Merging #271 (ac08953) into main (c62c902) will decrease coverage by 3.03%.
The diff coverage is 83.90%.

@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
- Coverage   96.31%   93.29%   -3.03%     
==========================================
  Files          53       66      +13     
  Lines        2227     2909     +682     
  Branches      174      233      +59     
==========================================
+ Hits         2145     2714     +569     
- Misses         58      156      +98     
- Partials       24       39      +15
Files Changed Coverage Δ
numalogic/registry/redis_registry.py 97.69% <ø> (ø)
numalogic/tools/data.py 95.65% <ø> (ø)
numalogic/tools/types.py 92.85% <ø> (ø)
numalogic/udfs/__main__.py 0.00% <0.00%> (ø)
numalogic/udfs/factory.py 55.55% <55.55%> (ø)
numalogic/connectors/redis.py 71.42% <71.42%> (ø)
numalogic/udfs/preprocess.py 77.21% <77.21%> (ø)
numalogic/udfs/__init__.py 81.25% <81.25%> (ø)
numalogic/udfs/_config.py 83.33% <83.33%> (ø)
numalogic/udfs/postprocess.py 85.91% <85.91%> (ø)
... and 13 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ab93
fix lints
d056a02 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
fix: ci errors
fb6915d 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
fix: postprocess perf
6b62679 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 changed the title Fix conflicts backtest feat!: numalogic udfs Aug 29, 2023
@ab93 ab93 marked this pull request as ready for review August 29, 2023 19:05
@ab93 ab93 requested a review from vigith August 29, 2023 19:06
@ab93
fix: logging
f4ff3ac 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
s0nicboOm and others added 2 commits August 29, 2023 12:32
@s0nicboOm
feat: add docker image release workflow (#274)
62364c9 
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@ab93
feat: log from file conf
9914b4c 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@vigith
Copy link
Member

vigith commented Aug 29, 2023

LGTM

@ab93
fix: add connector test cases
2dcf1cf 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
nkoppisetty
nkoppisetty previously requested changes Aug 30, 2023
View reviewed changes
Copy link
Member

@nkoppisetty nkoppisetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just a few comments

numalogic/connectors/_config.py Outdated Show resolved Hide resolved
numalogic/connectors/druid.py Outdated Show resolved Hide resolved
numalogic/connectors/redis.py Show resolved Hide resolved
numalogic/udfs/__main__.py Show resolved Hide resolved
numalogic/udfs/_config.py Outdated Show resolved Hide resolved
numalogic/udfs/postprocess.py Show resolved Hide resolved
numalogic/udfs/preprocess.py Show resolved Hide resolved
numalogic/udfs/preprocess.py Show resolved Hide resolved
numalogic/udfs/tools.py Show resolved Hide resolved
numalogic/udfs/trainer.py Show resolved Hide resolved
s0nicboOm and others added 2 commits August 30, 2023 15:46
@s0nicboOm
fix: log config (#276)
be5183a 
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@ab93
chore: address comments
3581a82 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
s0nicboOm
s0nicboOm approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@s0nicboOm s0nicboOm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ab93 ab93 requested a review from nkoppisetty August 31, 2023 18:31
@ab93 ab93 dismissed nkoppisetty’s stale review August 31, 2023 18:32

Addressed changes

nkoppisetty
nkoppisetty approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@nkoppisetty nkoppisetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s0nicboOm
Fix cache (#278)
ac08953 
Add inference cache

---------

Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@ab93 ab93 merged commit de8930a into main Aug 31, 2023
9 of 10 checks passed
@ab93 ab93 deleted the fix-conflicts-backtest branch August 31, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkoppisetty nkoppisetty nkoppisetty approved these changes

@s0nicboOm s0nicboOm s0nicboOm approved these changes

@qhuai qhuai Awaiting requested review from qhuai qhuai is a code owner

@vigith vigith Awaiting requested review from vigith

Assignees

@ab93 ab93

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ab93 @vigith @nkoppisetty @s0nicboOm