-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: numalogic udfs #271
Conversation
ab93
commented
Aug 29, 2023
•
edited
Loading
edited
- add numalogic udf module
- preproc, inference, postproc and trainer udfs
- config updates and factory classes
- dockerfile
- image release github action
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <avik_basu@intuit.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Preprocess udf --------- Signed-off-by: Kushal Batra <34571348+s0nicboOm@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Add PostProc --------- Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Get config from constructor for Preproc and Postproc Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com> Signed-off-by: Kushal Batra <34571348+s0nicboOm@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
1. Add publisher 2. Add test cases for preproc and postproc Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #271 +/- ##
==========================================
- Coverage 96.31% 93.29% -3.03%
==========================================
Files 53 66 +13
Lines 2227 2909 +682
Branches 174 233 +59
==========================================
+ Hits 2145 2714 +569
- Misses 58 156 +98
- Partials 24 39 +15
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
6771a73
to
f4ff3ac
Compare
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
LGTM |
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, just a few comments
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add inference cache --------- Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>