Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use well-defined dimensions instead of strings #283

Closed
wants to merge 3 commits into from

Conversation

cosmic-chichu
Copy link
Contributor

Using dimensions as a list of strings causes ambiguity in other druid clients. Well-defined dimensions makes use of the utility in pydruid to create dimensions as DimensionSpec. This helps with deterministic serialization and de-serialization of the query.

use well-defined dimensions instead of strings
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #283 (f91ea65) into main (de8930a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head f91ea65 differs from pull request most recent head 0c674f8. Consider uploading reports for the commit 0c674f8 to get more accurate results

@@           Coverage Diff           @@
##             main     #283   +/-   ##
=======================================
  Coverage   93.29%   93.30%           
=======================================
  Files          66       66           
  Lines        2909     2913    +4     
  Branches      233      234    +1     
=======================================
+ Hits         2714     2718    +4     
  Misses        156      156           
  Partials       39       39           
Files Changed Coverage Δ
numalogic/connectors/druid.py 87.80% <100.00%> (+1.31%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Shrivardhan Rao added 2 commits September 12, 2023 16:17
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant