Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use well-defined dimensions instead of strings #283

Closed
wants to merge 3 commits into from
Closed

feat: use well-defined dimensions instead of strings #283

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f91ea65
Signed-off-by: Shrivardhan Rao shrivardhan92@gmail.com
Sep 12, 2023
aca7a5d
use well-defined dimensions instead of strings
Sep 12, 2023
0c674f8
Merge branch 'main' of https://github.com/cosmic-chichu/numalogic
Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion numalogic/connectors/druid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import pandas as pd
import pytz
from pydruid.client import PyDruid
from pydruid.utils.dimensions import DimensionSpec
from pydruid.utils.filters import Filter
from numalogic.connectors._config import Pivot
from typing import Optional
Expand Down Expand Up @@ -50,13 +51,17 @@ def fetch_data(
start_dt = end_dt - timedelta(hours=hours)
intervals = f"{start_dt.isoformat()}/{end_dt.isoformat()}"

dimension_specs = []
for d in dimensions:
dimension_specs.append(DimensionSpec(dimension=d, output_name=d))

params = {
"datasource": datasource,
"granularity": granularity,
"intervals": intervals,
"aggregations": aggregations,
"filter": _filter,
"dimensions": dimensions,
"dimensions": dimension_specs,
}

_LOGGER.debug(
Expand Down