Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: udf server start error #294

Merged
merged 2 commits into from
Sep 20, 2023
Merged

fix: udf server start error #294

merged 2 commits into from
Sep 20, 2023

Conversation

ab93
Copy link
Member

@ab93 ab93 commented Sep 20, 2023 •
edited
Loading

  • add unit tests
  • bump version
  • make tag

@ab93
fix: udf server start error
ee17615 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 self-assigned this Sep 20, 2023
@ab93
chore: add make tag
709e8dd 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 marked this pull request as ready for review September 20, 2023 22:23
@ab93 ab93 added the bug Something isn't working label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #294 (709e8dd) into main (f55312b) will increase coverage by 0.53%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
+ Coverage   93.29%   93.82%   +0.53%     
==========================================
  Files          74       74              
  Lines        3384     3386       +2     
  Branches      277      277              
==========================================
+ Hits         3157     3177      +20     
+ Misses        177      157      -20     
- Partials       50       52       +2
Files Changed Coverage Δ
numalogic/udfs/__main__.py 57.69% <85.71%> (+57.69%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

nkoppisetty
nkoppisetty approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@nkoppisetty nkoppisetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ab93 ab93 merged commit 98e376a into main Sep 20, 2023
10 checks passed
@ab93 ab93 deleted the fix-udf branch September 20, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkoppisetty nkoppisetty nkoppisetty approved these changes

@qhuai qhuai Awaiting requested review from qhuai qhuai is a code owner

@s0nicboOm s0nicboOm Awaiting requested review from s0nicboOm s0nicboOm is a code owner

Assignees

@ab93 ab93

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ab93 @nkoppisetty