-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix druid connector with tests #296
Conversation
cosmic-chichu
commented
Sep 21, 2023
- decouple method to increase testability
- remove extraneous subquery
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
use generator Co-authored-by: Avik Basu <3485425+ab93@users.noreply.github.com> Signed-off-by: shrivardhan <shrivardhan92@gmail.com>
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Codecov Report
@@ Coverage Diff @@
## main #296 +/- ##
=======================================
Coverage 93.82% 93.83%
=======================================
Files 74 74
Lines 3386 3390 +4
Branches 277 276 -1
=======================================
+ Hits 3177 3181 +4
Misses 157 157
Partials 52 52
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>