fix druid connector with tests #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cosmic-chichu
commented
Sep 21, 2023
cosmic-chichu
commented
- decouple method to increase testability
- remove extraneous subquery
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
use generator Co-authored-by: Avik Basu <3485425+ab93@users.noreply.github.com> Signed-off-by: shrivardhan <shrivardhan92@gmail.com>
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
cosmic-chichu
requested review from
ab93,
qhuai,
nkoppisetty and
s0nicboOm
as code owners
added 2 commits
September 21, 2023 15:11
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Codecov Report
@@ Coverage Diff @@
## main #296 +/- ##
=======================================
Coverage 93.82% 93.83%
=======================================
Files 74 74
Lines 3386 3390 +4
Branches 277 276 -1
=======================================
+ Hits 3177 3181 +4
Misses 157 157
Partials 52 52
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ab93
reviewed
Sep 21, 2023
ab93
reviewed
Sep 21, 2023
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
ab93
approved these changes
Sep 22, 2023
nkoppisetty
approved these changes
Sep 22, 2023
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.