fix(src/modal/modal-manager.ts): avoid creating modal when not necessary

Signed-off-by: James Chien <james@numbersprotocol.io>
numbersprotocol · Dec 5, 2024 · 28bc7a2 · 28bc7a2
1 parent a867437
commit 28bc7a2
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/src/modal/modal-manager.ts b/src/modal/modal-manager.ts
@@ -64,10 +64,10 @@ export class ModalManager {
   }
 
   removeModal(): void {
-    const modal = this.getModal();
-    modal.modalHidden = true;
+    if (!this.modalElement) return;
+    this.modalElement.modalHidden = true;
     this.unregisterRootClickListener();
-    modal.remove();
+    this.modalElement.remove();
     this.modalElement = null;
   }
 
@@ -87,9 +87,8 @@ export class ModalManager {
     assetModel: AssetModel | undefined,
     setAsLoaded: boolean
   ) {
-    const modal = this.getModal();
-    if (!assetModel) return;
-    modal.updateAsset(assetModel, setAsLoaded);
+    if (!this.modalElement || !assetModel) return;
+    this.modalElement.updateAsset(assetModel, setAsLoaded);
   }
 
   private registerRootClickListener() {