fix(src/{capture-eye,modal/modal}.ts): fix engagement link default va…

…lue and tracking Signed-off-by: James Chien <james@numbersprotocol.io>
numbersprotocol · Oct 18, 2024 · 66c0aeb · 66c0aeb
1 parent a065d0e
commit 66c0aeb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/capture-eye.ts b/src/capture-eye.ts
@@ -42,13 +42,13 @@ export class CaptureEye extends LitElement {
    * Url of the engagement image.
    */
   @property({ type: String, attribute: 'eng-img' })
-  engagementImage = Constant.url.defaultEngagementImage;
+  engagementImage = '';
 
   /**
    * Url of the engagement link.
    */
   @property({ type: String, attribute: 'eng-link' })
-  engagementLink = Constant.url.defaultEngagementLink;
+  engagementLink = '';
 
   /**
    * Text of the action button.

diff --git a/src/modal/modal.ts b/src/modal/modal.ts
@@ -393,7 +393,11 @@ export class CaptureEyeModal extends LitElement {
     // 0: User-customized link (not provided by us)
     // 1: Default engagement link
     // 2, 3, ...: Future rotating engagement links
-    const subid = this._engagementLink ? '0' : '1';
+    const subid =
+      !this._engagementLink ||
+      this._engagementLink === Constant.url.defaultEngagementLink
+        ? '1'
+        : '0';
     interactionTracker.trackInteraction(
       TrackerEvent.ENGAGEMENT_ZONE,
       this.nid,