Add more verifiable data #2
Conversation
…e asset tree info and better capture details Signed-off-by: James Chien <james@numbersprotocol.io>
| 'xmp': 'http://ns.adobe.com/xap/1.0/' | ||
| }, | ||
| 'EXIF:GPSLatitude': format_geolocation(latitude), | ||
| 'EXIF:GPSLongitude': format_geolocation(longitude), |
There was a problem hiding this comment.
I'm not sure whether EXIF:GPSLatitude and EXIF:GPSLongitude match the EXIF spec as described in the link C2PA Specification. Other than that, it looks good to me.
There was a problem hiding this comment.
@olgahaha I took the field key and value format from Adobe Verify Tool Doc and the content could be displayed on Verify Tool.
It's different from the EXIF spec (DMS format), but after a quick search I didn't find a battle-tested library with a convenient method to convert it. Concerning there might be some corner cases I'd prefer staying with current format for now. We can have a task for chaning the formatting to DMS format used in EXIF, write good test to ensure the conversion is correct, and also checking with Adobe c2pa team for their tendency on continuing to support decimal degree format.
There was a problem hiding this comment.
@olgahaha Here is the taks for follow-up. https://app.asana.com/0/1201016280880508/1207538253204834/f Since other parts are ok I'll go ahead and merge and release the version.
Changed