Improve find command #219

KhooDesmond · 2016-11-05T18:26:11Z

No description provided.

Modify edit function

# Conflicts: # src/main/java/seedu/malitio/commons/core/Messages.java

# Conflicts: # src/main/java/seedu/malitio/model/Malitio.java

Support listing a specific type of task

Ensure valid events (fixes #33)

…ll as manual events and deadlines. 2) Update Event/DeadlineListPanelHandle to point to the correct fxml cardpane as well as correct fxml listview. 3) Filled in the method getSampleDeadline(Event)Data in TestUtil. 4) Update the overloaded methods addTasksToList so that it arranges the test list for events and deadlines according to the due and start times respectively. 5) Added more tests in AddCommandTest for Deadline and Event. However, duplicate deadline/event test commented out because not working yet.

Modify the getter methods in UniqueEvent(Deadline)List

Update junit test (Fixes #31)

2) Added throws illegalStateException in testcases with Event 3) Editted EventCardHandle to support checking for equivalent event (In list and displayed) 4) Collated my parts (might accidentally took yours so do check (: )

NOTE: Delete tests still not working

Refactor EditCommandTest

Modify format to follow java coding standard Add collation tags "//@@author A0129595N" for collation

…d_and_test Refactoring & ensure java coding standards are followed

Edit add and edit command

Add the restriction on task name

Update UserGuide.md

Update DeveloperGuide.md

…lines that has date format 11-Nov-2016, 22:00 (Fri)

# Conflicts: # src/main/java/seedu/malitio/logic/parser/Parser.java

refactor save command

…d times. edit parser to remove debugging message

nus-se-pr-bot · 2016-11-05T18:27:22Z

Hi @KhooDesmond, your pull request title is invalid. It should be in the format of [Activity ID][Team ID] Your name, where [Activity Id] has no dashes or spaces (e.g. [T2A3] stands for Tutorial 2 Activity 3) and [Team ID] has one dash only and no spaces (e.g. [W14-A2] means Wednesday 2pm (14 hrs), Phase A, Team 2). Please follow the instructions given strictly and edit your title for reprocessing.

Submit only one activity per pull request (unless otherwise stated in instructions) and do remember to create your branches from the commit where the master branch is pointing at so that each PR you submit only consist of commits meant for the activity.

Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at cs2103-pr-bot and add a link to this PR.

annabeleng and others added 30 commits October 19, 2016 15:12

Update link to UI image

f68b40b

Enhance find command to find only floating task, deadline or schedule

8e127fb

Fix bug that displays wrong find result

804e17e

Merge branch 'master' of https://github.com/CS2103AUG2016-T13-C3/main

89889ec

Update Parser to send the correct parameters to EditCommand

37b11d6

Refactor all tests to match latest model

462f384

Fixed error in DeadlineListPanel

fdebb77

Support deletion of events and deadlines

121cfa2

Merge pull request #26 from CS2103AUG2016-T13-C3/modify_edit_function

f6ba06a

Modify edit function

Merge branch 'find_command'

7f66c81

# Conflicts: # src/main/java/seedu/malitio/commons/core/Messages.java

Merge branch 'delete_command'

873e58f

# Conflicts: # src/main/java/seedu/malitio/model/Malitio.java

Fix some minor errors caused by merge.

96c5ef0

Support listing a specific type of task

4d819d5

Fix delete function

9248b45

Merge pull request #30 from CS2103AUG2016-T13-C3/list_command

dd2e126

Support listing a specific type of task

Fix error in test case

de1563a

Update Storage API documentation, fixes #18

a7d378c

Make sure events start time is before end time

48ccc91

Fix some errors, ensure editted events have start time before end time

f0d3821

Merge pull request #34 from CS2103AUG2016-T13-C3/ensure_valid_events

336401b

Ensure valid events (fixes #33)

Fixed bugs in delete command

9fbfe33

Fix shadowJar creation

df4b17d

Update Model Class Diagram

de0d6ac

Remove duplicate getter methods for due, start and end.

ff82933

Modify the getter methods in UniqueEvent(Deadline)List

Merge pull request #32 from CS2103AUG2016-T13-C3/update_junit_test

d87b775

Update junit test (Fixes #31)

1) Corrected isSameStateAs() in ReadOnlyDeadline/Event.

6e8cb8c

2) Added throws illegalStateException in testcases with Event 3) Editted EventCardHandle to support checking for equivalent event (In list and displayed) 4) Collated my parts (might accidentally took yours so do check (: )

Remove Select Command as well as its related tests

87b8329

NOTE: Delete tests still not working

Undo Command supports undo of add and delete commands

c1e6cbb

Undo command can now undo after edit command has been called

bb79d8c

annabeleng and others added 27 commits November 5, 2016 13:19

Refactor EditCommand

ce86120

Refactor EditCommandTest

display day of week, fix find command to accommodate this change

3a76457

Update README.md

3f007bc

Add header comments for methods in some classes.

325b796

Modify format to follow java coding standard Add collation tags "//@@author A0129595N" for collation

Merge pull request #85 from CS2103AUG2016-T13-C3/refactor_edit_comman…

b99c805

…d_and_test Refactoring & ensure java coding standards are followed

Update UserGuide.md

1309833

Edit add and edit command

Update UserGuide.md

0748160

Add the restriction on task name

Merge pull request #87 from CS2103AUG2016-T13-C3/annabeleng-patch-1

604deb7

Update UserGuide.md

Update UserGuide.md

983d805

Merge pull request #88 from CS2103AUG2016-T13-C3/annabeleng-patch-2

3295b65

Update UserGuide.md

Update UserGuide.md

4f7b479

Merge pull request #89 from CS2103AUG2016-T13-C3/annabeleng-patch-3

aff29ad

Update UserGuide.md

Update DeveloperGuide.md

3396132

Remove browser icon from architecture

1c171ba

Merge pull request #90 from CS2103AUG2016-T13-C3/annabeleng-patch-4

37fb6ab

Update DeveloperGuide.md

Fix bug with parsing, in particular parsing name from events and dead…

5e9efc5

…lines that has date format 11-Nov-2016, 22:00 (Fri)

Merge branch 'display_date_format'

6252717

# Conflicts: # src/main/java/seedu/malitio/logic/parser/Parser.java

Fix add deadline bug

000e684

refactor save command

d1df69f

Merge pull request #92 from CS2103AUG2016-T13-C3/refactor_save_command

6cc579b

refactor save command

fixed bug in index error

5cc1b4b

Edit message for already marked and unmarked tasks

dc98c2f

edit parser to display correct error message for missing start and en…

edbaedb

…d times. edit parser to remove debugging message

Merge branch 'master' of https://github.com/CS2103AUG2016-T13-C3/main

06e911c

edit EditCommand to check for invalid use of keywords

4b962cb

more inclusive save directory format

55207c5

find now only searches tasks in the last shown list

b1c555f

nus-se-pr-bot added the FormatCheckRequested label Nov 5, 2016

Fix listcommand failing bug

e39c743

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve find command #219

Improve find command #219

KhooDesmond commented Nov 5, 2016

nus-se-pr-bot commented Nov 5, 2016

Improve find command #219

Are you sure you want to change the base?

Improve find command #219

Conversation

KhooDesmond commented Nov 5, 2016

nus-se-pr-bot commented Nov 5, 2016