Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[T7][T15-C2] #92

Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

[T7][T15-C2] #92

wants to merge 49 commits into from

Conversation

zhengyu92
Copy link

Work in progress

Copy link

@K1ang K1ang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhengyu92 @chankyuoh @Niveetha @takukou
Good job in doing up this userguide!
Most of your commands seems user friendly.
There are some parts that can still be thought through more thoroughly to have a better design for your application.

2. Scheduler shows a list of items or the item
3. User calls the edit function
4. User types in index of item and inputs new values for the item
5. Scheduler displays updated list of items <br>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is displaying the list of items necessary? Or just the details of the updated item will be better.

2a. The list is empty

> 2a1. Scheduler displays empty list <br>

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More thinking through is required for this function. What does it mean by tracking items which are done and which are yet to be done? You can consider functions to allow the user to mark a task to be completed. And how should a user list completed/uncompleted task?

* **`exit`** : exits the app
* **`list`** : lists all tasks
* **`add`**` `add Do Homework d/ 19/02/12 t/13:43 n/ cs2103 homework` :
adds a task named `Do Homework` to the Task List.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent with the details of add command in the features section.

**MSS**

1. User calls the find function
2. Scheduler displays the items that are word related with no case sensitive
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ambiguous here. What is word related?

Clears all entries from the address book.<br>
Format: `clear`
* `find Tutorial`<br>
Returns `CS2103 Tutorial` and words related to `tutorial`
Copy link

@K1ang K1ang Oct 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does related means? Can be more specific for this.

* `find Tutorial`<br>
Returns `CS2103 Tutorial` and words related to `tutorial`
* `find CS Assignment Errand`<br>
Returns Any item having names `CS`, `Assignment`, or `Errand`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this return "any item" that matches either of the multiple keywords (1 item only) or all items that matches with either of the keywords?

-----
#### [Henderson](http://github.com/takukou)
Role: Developer <br>
Responsibilities: Storage

Copy link

@K1ang K1ang Oct 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out the handbook on some possible roles and responsibilities other than developer. :)

There is no need to save manually.
#### Saving the data: `path`
Scheduler data are saved in the hard disk automatically after any command that changes the data. File path can be manually changed to a user-specified location.<br>
Format: `path FILE_PATH`

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saving the data and setting a new file path should be separated into different components.

@K1ang
Copy link

K1ang commented Oct 8, 2016

Some comments added. Please close the PR after reading comments.

@K1ang K1ang added the Reviewed label Oct 8, 2016
zhengyu92 and others added 10 commits October 10, 2016 18:40
# Conflicts:
#	docs/DeveloperGuide.md
#	docs/UserGuide.md
* commandChange:
  Change all relevant 'address' to 'date'
  Rename all 'email' to 'endDateTime'
  Rename all 'phone' to 'startDateTime'
  Change all 'person' to 'task'
  Delete SelectCommand.java and related codes

# Conflicts:
#	docs/DeveloperGuide.md
#	docs/UserGuide.md
* 'master' of https://github.com/CS2103AUG2016-T15-C2/main:

# Conflicts:
#	docs/DeveloperGuide.md
#	docs/UserGuide.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants