Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[w6.1h][T14-B1]Xu Jun #893

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

willxujun
Copy link

No description provided.

Copy link

@K1ang K1ang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willxujun good attempt! Keep it up.

String result = "";
for (Printable i: printables) {
result = result + i.getPrintableString();
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the Java StringJoiner class to perform this more effectively.

@@ -0,0 +1,5 @@
package seedu.addressbook.data.person;

public interface Printable {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing header comment. All non trivial methods and classes should have javadoc format header comments.

@K1ang K1ang added the Reviewed label Oct 8, 2017
@K1ang
Copy link

K1ang commented Oct 8, 2017

Some comments added. Please close the PR after reading comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants