[W5.4r][F09-B4] Liu Hang #926
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
September 21, 2017 13:25
See comments for detail
|
@liuhang0213 take note of your team id. @jeffryhartanto tagged you in this PR. |
|
@satyam-cyc Please review this PR. |
satyam-cyc
requested changes
Oct 10, 2017
| @@ -60,12 +60,24 @@ public void listCommand_parsedCorrectly() { | |||
| } | |||
|
|
|||
| @Test | |||
| public void sortCommand_parsedCorrectly() { | |||
| public void sortCommand_noArgs_parsedCorrectly() { | |||
There was a problem hiding this comment.
You have successfully implemented Unit tests!
But you still need to add IO tests for your feature.
IO tests help assess the end-to-end correctness of a program.
You will need to add input.txt and expected.txt files along with a batch script to compare your programs output to the expected output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.