Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W5.4r][F09-B4] Liu Hang #926

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

[W5.4r][F09-B4] Liu Hang #926

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5fa7fc0
Adds isMutating method()
Sep 21, 2017
861b9e1
Checks for isMutating before save
Sep 21, 2017
95a6b84
Fixes failed test cases
Sep 21, 2017
b056d59
Adds sort command
Oct 5, 2017
f9e1c35
Makes Person class comparable
Oct 5, 2017
ecbea9d
Implements sorting methods
Oct 5, 2017
1511e1a
Implements execute method for SortCommand
Oct 5, 2017
8a418d1
ncludes sort command into parser
Oct 5, 2017
0335194
Adds test case for sort command
Oct 5, 2017
ce7300b
Adds optional argument to indicate sorting order
Oct 5, 2017
18f9fa6
Adds methods to sort in reverse order
Oct 5, 2017
51ab1f1
Allows parser to take in 1 optional argument
Oct 5, 2017
1da1dba
Prepares argument for SortCommand
Oct 5, 2017
5d628e6
Updates test case
Oct 5, 2017
94768eb
Removes extra debugging line
Oct 5, 2017
6337bc5
Updates command usage
Oct 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions test/java/seedu/addressbook/parser/ParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,23 @@ public void listCommand_parsedCorrectly() {
}

@Test
public void sortCommand_parsedCorrectly() {
public void sortCommand_noArgs_parsedCorrectly() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have successfully implemented Unit tests!

But you still need to add IO tests for your feature.
IO tests help assess the end-to-end correctness of a program.
You will need to add input.txt and expected.txt files along with a batch script to compare your programs output to the expected output.

final String input = "sort";
parseAndAssertCommandType(input, SortCommand.class);
}

@Test
public void sortCommand_asc_parsedCorrectly() {
final String input = "sort asc";
parseAndAssertCommandType(input, SortCommand.class);
}

@Test
public void sortCommand_desc_parsedCorrectly() {
final String input = "sort desc";
parseAndAssertCommandType(input, SortCommand.class);
}

@Test
public void exitCommand_parsedCorrectly() {
final String input = "exit";
Expand Down Expand Up @@ -141,7 +153,15 @@ public void viewAllCommand_numericArg_indexParsedCorrectly() {
final ViewAllCommand result = parseAndAssertCommandType(input, ViewAllCommand.class);
assertEquals(result.getTargetIndex(), testIndex);
}


@Test
public void sortCommand_wrongArg() {
final String[] inputs = { "sort a", "sort sdfd" };
final String resultMessage =
String.format(MESSAGE_INVALID_COMMAND_FORMAT, SortCommand.MESSAGE_USAGE);
parseAndAssertIncorrectWithMessage(resultMessage, inputs);
}

/**
* Test find persons by keyword in name command
*/
Expand Down