-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Level 1 to 3 (Week 2) #1
Open
tototto
wants to merge
86
commits into
nus-tic4001-AY2021S1:master
Choose a base branch
from
tototto:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
86 commits
Select commit
Hold shift + click to select a range
3b19ba1
Add Gradle support
269e3ff
Level 1 to 3
tototto 0f09980
Finished Level 4
tototto d20f84a
A-TextUiTesting
tototto eeb75ba
A-CodingStandard
tototto 5d75ff9
branch-Level-5
tototto f6cdbf9
Merge tag 'branch-Level-5'
tototto c5d61c0
Made Task abstract
9624640
Merge A-AbstractClasses increment with Master
a75fcee
build.gradle: Update version to 8.29
61b84e7
Completed A-CodeQuality
fe09317
Merging branch-A-CodeQuality with Master
dc20b21
created Packages for Duke and re-solved Shell Script issues for Testing
73953a7
Merged branch-A-Packages with Master
1be5731
completed branch-Level-6
365f5a8
Merge pull request #1 from tototto/branch-Level-6
tototto 7a2fa8a
branch-Level-7 added File IO operation
2ee965d
added demonstration of using displayHandler to print messages for Rea…
a28ce65
branch-A-JavaDoc added some java docs
4e3bb94
Merge branch 'branch-Level-7'
00f14ef
completed A-MoreOOP, refactored code out to individual classes/compon…
1471017
completed branch-Level-9
4578c64
add Junit testcases
7c0bebd
Merge pull request #2 from tototto/branch-A-JUnit
tototto 02fc569
resolve merge conflict when merging master to branch-Level-9
cbe13a9
Merge pull request #3 from tototto/branch-Level-9
tototto a1a2066
commiting
fd6ead5
resolved local merge conflict with the version from Git Pull
ef20fc2
Created User Guide
tototto 9991603
Changed format
tototto bd7293b
Update README.md
tototto 7adebbe
Set theme jekyll-theme-slate
tototto 0bea941
Update README.md
tototto f134e03
Update README.md
tototto d54b09a
add gradle support from upstream
673a84c
Merge branch 'branch-A-Gradle'
839b98c
Merge branch 'master' of https://github.com/tototto/ip
9c940b8
introduced JavaFX
859a1bc
Implement working JavaFX UI
1ec8b9a
competed working JavaFX for Duke
8d1655d
Finish building FXML
0ec3d22
refactor into packages of FXML implementation
a7badc2
Merge branch 'branch-Level-10'
c349451
attempted to improve coding standard
fe0fd54
added A Stricter Coding Standard
1250f58
Create yml file for CI
tototto 5848c81
fixed yml syntax
tototto 76b918f
added an extension from category C (C-Help)
bb13edd
Merge branch 'master' of https://github.com/tototto/ip
b537754
updated checkstyle.xml to remove suppresion filter dependency
dd66300
added suppresion filter dependency back and created suppression.xml
b72459a
fixed checkstyle in FileManager
897efa7
fixed remaning checkstyle error found in CI
1d01229
pushing code with junit issue to repo so others can take a look
6cb4a7a
fixed issue where project cannot build Junit using Gradle
c3ebc0c
fixed checkstyle for Junit
0146c6b
Update README.md
tototto 456113a
Update README.md
tototto db1c81f
Update README.md
tototto 3c390c0
Update README.md
tototto e0a403d
Set theme jekyll-theme-merlot
tototto 25c4f7f
Create UserGuide.md
tototto d64cd84
Create DeveloperGuide.md
tototto c53b4b1
Update UserGuide.md
tototto f106611
Update README.md
tototto 6ddfe40
Update README.md
tototto 52be408
Update UserGuide.md
tototto bab01ec
Create image
tototto dd338ae
Add files via upload
tototto 378bdd5
Delete image
tototto ae407e1
Update DeveloperGuide.md
tototto 6f52eee
Update DeveloperGuide.md
tototto 624fc46
Update DeveloperGuide.md
tototto 776906a
Update DeveloperGuide.md
tototto 916bef1
Update DeveloperGuide.md
tototto 282404e
Update DeveloperGuide.md
tototto d7af8a7
Update DeveloperGuide.md
tototto a948fa5
Update DeveloperGuide.md
tototto 77d1975
Update DeveloperGuide.md
tototto 2d62376
Update DeveloperGuide.md
tototto dc753fa
added Ui.png to meet submission requirmenet
tototto 474e3c2
Update README.md
tototto a879088
Update README.md
tototto 283a704
Update README.md
tototto 9e5ecac
Update README.md
tototto 435a4b8
Update README.md
tototto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
10 changes: 4 additions & 6 deletions
10
src/main/java/commandHandler.java → src/main/java/CommandHandler.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/main/java/displayHandler.java → src/main/java/DisplayHandler.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/main/java/inputHandler.java → src/main/java/InputHandler.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/main/java/inputParser.java → src/main/java/InputParser.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
public class inputParser { | ||
public class InputParser { | ||
|
||
// Check if First Word is Keyword | ||
public boolean checkIfKeyWord(String Input) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if is boolean, hasKeyword/isKeyword would be a better naming? InputParser.isKeyword("abc"). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. Indeed it would be. Thank you. |
||
|
2 changes: 1 addition & 1 deletion
2
src/main/java/listHandler.java → src/main/java/ListHandler.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the naming convention, Variable names must be in camelCase.
displayUnit, inputUnit and etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out. I missed this while refactoring.