Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level 1 to 3 (Week 2) #1

Open
wants to merge 86 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
86 commits
Select commit Hold shift + click to select a range
3b19ba1
Add Gradle support
May 24, 2020
269e3ff
Level 1 to 3
tototto Aug 15, 2020
0f09980
Finished Level 4
tototto Aug 22, 2020
d20f84a
A-TextUiTesting
tototto Aug 28, 2020
eeb75ba
A-CodingStandard
tototto Aug 28, 2020
5d75ff9
branch-Level-5
tototto Aug 29, 2020
f6cdbf9
Merge tag 'branch-Level-5'
tototto Aug 29, 2020
c5d61c0
Made Task abstract
Aug 29, 2020
9624640
Merge A-AbstractClasses increment with Master
Aug 29, 2020
a75fcee
build.gradle: Update version to 8.29
Aug 29, 2020
61b84e7
Completed A-CodeQuality
Aug 30, 2020
fe09317
Merging branch-A-CodeQuality with Master
Aug 30, 2020
dc20b21
created Packages for Duke and re-solved Shell Script issues for Testing
Aug 30, 2020
73953a7
Merged branch-A-Packages with Master
Aug 30, 2020
1be5731
completed branch-Level-6
Sep 4, 2020
365f5a8
Merge pull request #1 from tototto/branch-Level-6
tototto Sep 4, 2020
7a2fa8a
branch-Level-7 added File IO operation
Sep 6, 2020
2ee965d
added demonstration of using displayHandler to print messages for Rea…
Sep 6, 2020
a28ce65
branch-A-JavaDoc added some java docs
Sep 6, 2020
4e3bb94
Merge branch 'branch-Level-7'
Sep 6, 2020
00f14ef
completed A-MoreOOP, refactored code out to individual classes/compon…
Sep 12, 2020
1471017
completed branch-Level-9
Sep 12, 2020
4578c64
add Junit testcases
Sep 12, 2020
7c0bebd
Merge pull request #2 from tototto/branch-A-JUnit
tototto Sep 12, 2020
02fc569
resolve merge conflict when merging master to branch-Level-9
Sep 12, 2020
cbe13a9
Merge pull request #3 from tototto/branch-Level-9
tototto Sep 12, 2020
a1a2066
commiting
Sep 12, 2020
fd6ead5
resolved local merge conflict with the version from Git Pull
Sep 12, 2020
ef20fc2
Created User Guide
tototto Sep 18, 2020
9991603
Changed format
tototto Sep 18, 2020
bd7293b
Update README.md
tototto Sep 18, 2020
7adebbe
Set theme jekyll-theme-slate
tototto Sep 18, 2020
0bea941
Update README.md
tototto Sep 19, 2020
f134e03
Update README.md
tototto Sep 28, 2020
d54b09a
add gradle support from upstream
Jan 19, 2021
673a84c
Merge branch 'branch-A-Gradle'
Jan 19, 2021
839b98c
Merge branch 'master' of https://github.com/tototto/ip
Jan 19, 2021
9c940b8
introduced JavaFX
Jan 24, 2021
859a1bc
Implement working JavaFX UI
Jan 26, 2021
1ec8b9a
competed working JavaFX for Duke
Jan 27, 2021
8d1655d
Finish building FXML
Jan 27, 2021
0ec3d22
refactor into packages of FXML implementation
Jan 28, 2021
a7badc2
Merge branch 'branch-Level-10'
Jan 28, 2021
c349451
attempted to improve coding standard
Jan 29, 2021
fe0fd54
added A Stricter Coding Standard
Jan 29, 2021
1250f58
Create yml file for CI
tototto Jan 31, 2021
5848c81
fixed yml syntax
tototto Jan 31, 2021
76b918f
added an extension from category C (C-Help)
Jan 31, 2021
bb13edd
Merge branch 'master' of https://github.com/tototto/ip
Jan 31, 2021
b537754
updated checkstyle.xml to remove suppresion filter dependency
Jan 31, 2021
dd66300
added suppresion filter dependency back and created suppression.xml
Jan 31, 2021
b72459a
fixed checkstyle in FileManager
Jan 31, 2021
897efa7
fixed remaning checkstyle error found in CI
Jan 31, 2021
1d01229
pushing code with junit issue to repo so others can take a look
Jan 31, 2021
6cb4a7a
fixed issue where project cannot build Junit using Gradle
Jan 31, 2021
c3ebc0c
fixed checkstyle for Junit
Jan 31, 2021
0146c6b
Update README.md
tototto Feb 5, 2021
456113a
Update README.md
tototto Feb 5, 2021
db1c81f
Update README.md
tototto Feb 5, 2021
3c390c0
Update README.md
tototto Feb 5, 2021
e0a403d
Set theme jekyll-theme-merlot
tototto Feb 12, 2021
25c4f7f
Create UserGuide.md
tototto Feb 12, 2021
d64cd84
Create DeveloperGuide.md
tototto Feb 12, 2021
c53b4b1
Update UserGuide.md
tototto Feb 12, 2021
f106611
Update README.md
tototto Feb 12, 2021
6ddfe40
Update README.md
tototto Feb 12, 2021
52be408
Update UserGuide.md
tototto Feb 12, 2021
bab01ec
Create image
tototto Feb 13, 2021
dd338ae
Add files via upload
tototto Feb 13, 2021
378bdd5
Delete image
tototto Feb 13, 2021
ae407e1
Update DeveloperGuide.md
tototto Feb 13, 2021
6f52eee
Update DeveloperGuide.md
tototto Feb 13, 2021
624fc46
Update DeveloperGuide.md
tototto Feb 13, 2021
776906a
Update DeveloperGuide.md
tototto Feb 13, 2021
916bef1
Update DeveloperGuide.md
tototto Feb 13, 2021
282404e
Update DeveloperGuide.md
tototto Feb 13, 2021
d7af8a7
Update DeveloperGuide.md
tototto Feb 13, 2021
a948fa5
Update DeveloperGuide.md
tototto Feb 13, 2021
77d1975
Update DeveloperGuide.md
tototto Feb 13, 2021
2d62376
Update DeveloperGuide.md
tototto Feb 14, 2021
dc753fa
added Ui.png to meet submission requirmenet
tototto Feb 22, 2021
474e3c2
Update README.md
tototto Feb 23, 2021
a879088
Update README.md
tototto Feb 23, 2021
283a704
Update README.md
tototto Feb 23, 2021
9e5ecac
Update README.md
tototto Feb 23, 2021
435a4b8
Update README.md
tototto Feb 23, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
//import jdk.internal.util.xml.impl.Input;

import java.util.Vector;
public class CommandHandler {

public class commandHandler {
DisplayHandler DisplayUnit = new DisplayHandler();
InputParser InputUnit = new InputParser();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the naming convention, Variable names must be in camelCase.
displayUnit, inputUnit and etc.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. I missed this while refactoring.


displayHandler DisplayUnit = new displayHandler();
inputParser InputUnit = new inputParser();

public void checkCommandType(String KeyWord, String Body, listHandler List) {
public void checkCommandType(String KeyWord, String Body, ListHandler List) {

KEYWORD keyword = KEYWORD.valueOf(KeyWord.toUpperCase());

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import java.util.Vector;
import java.util.*;

public class displayHandler {
public class DisplayHandler {

final private String LOGO_ICON = " ____ _ \n"
+ "| _ \\ _ _| | _____ \n"
Expand Down
12 changes: 5 additions & 7 deletions src/main/java/Duke.java
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
import java.util.Vector;

public class Duke {
public static void main(String[] args) {

// Instantiate program components
displayHandler DisplayUnit = new displayHandler();
inputHandler InputUnit = new inputHandler();
inputParser Parser = new inputParser();
listHandler List = new listHandler();
commandHandler Command = new commandHandler();
DisplayHandler DisplayUnit = new DisplayHandler();
InputHandler InputUnit = new InputHandler();
InputParser Parser = new InputParser();
ListHandler List = new ListHandler();
CommandHandler Command = new CommandHandler();

// Uses a Facade to Manage Individual Modular Components
DisplayUnit.ProgramOpening();
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import java.util.Scanner;

public class inputHandler {
public class InputHandler {

static private Scanner fromInputStream = new Scanner(System.in);

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
public class inputParser {
public class InputParser {

// Check if First Word is Keyword
public boolean checkIfKeyWord(String Input) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if is boolean, hasKeyword/isKeyword would be a better naming?

InputParser.isKeyword("abc").

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Indeed it would be. Thank you.

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import java.util.*;

public class listHandler {
public class ListHandler {

private Vector ListStorage = new Vector();

Expand Down