-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Olivier] - IP PR #10
base: master
Are you sure you want to change the base?
Conversation
…h the requirement. Level04 requirement.
…h the requirement. Level04 requirement.
…h the requirement. Level04 requirement.
…ow proper Duke Exception.
Renaming variable for better readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well structured project and also following good coding standing. Easy to understand and each function plays its own part.
src/main/java/duke/Duke.java
Outdated
System.out.println(e.getMessage()); | ||
} | ||
fullCommand = ui.readUserCommand().toLowerCase(); | ||
commandWord = Parser.getCommandWord(fullCommand); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused code? Is it necessary?
src/main/java/utils/Parser.java
Outdated
try { | ||
String deadline = fullCommand.substring(fullCommand.indexOf("/by")) | ||
.replace("/by", "").trim(); | ||
if (deadline.isEmpty()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good usage of isEmpty function
src/main/java/utils/Parser.java
Outdated
} | ||
} | ||
|
||
public static int getTaskIndex(String fullCommand) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can add exception handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Overall the code quality is very good. Good adherence to coding standards. I was not able to detect any outstanding violations 👍
# Conflicts: # src/main/java/duke/Deadline.java
Added search function for level 9
added junit testing and modify tasklist to create function to test pr…
…r in the directory
…r in the directory
Merging Gradle Branch to master
added checkstyle implementation.
added checkstyle implementation.
Updated README.md Added UG and DG. Added UI.
# Conflicts: # docs/_config.yml
UPDATED README
Add some paragraph to the README.md to explain ...
Also add a heading ...