Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Olivier] - IP PR #10

Open
wants to merge 63 commits into
base: master
Choose a base branch
from
Open

Conversation

skyventus
Copy link

Add some paragraph to the README.md to explain ...
Also add a heading ...

@skyventus skyventus changed the title Add an introduction to the README.md [Olivier] - IP PR Aug 24, 2020
Copy link

@timmyly7 timmyly7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well structured project and also following good coding standing. Easy to understand and each function plays its own part.

System.out.println(e.getMessage());
}
fullCommand = ui.readUserCommand().toLowerCase();
commandWord = Parser.getCommandWord(fullCommand);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused code? Is it necessary?

try {
String deadline = fullCommand.substring(fullCommand.indexOf("/by"))
.replace("/by", "").trim();
if (deadline.isEmpty())
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good usage of isEmpty function

}
}

public static int getTaskIndex(String fullCommand) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add exception handling

Copy link

@adi-kd0021 adi-kd0021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Overall the code quality is very good. Good adherence to coding standards. I was not able to detect any outstanding violations 👍

skyventus and others added 30 commits September 10, 2020 21:50
# Conflicts:
#	src/main/java/duke/Deadline.java
Added search function for level 9
added junit testing and modify tasklist to create function to test pr…
Merging Gradle Branch to master
added checkstyle implementation.
added checkstyle implementation.
Updated README.md
Added UG and DG.
Added UI.
# Conflicts:
#	docs/_config.yml
UPDATED README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants