[Adi Kesava] iP #11
Open
[Adi Kesava] iP #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slight modification
daiweinus
reviewed
Sep 4, 2020
src/Duke/ui/Ui.java
Outdated
| /** | ||
| * Prints "Your task?" | ||
| * | ||
| * @return the line read in after trimming trailing and leading spaces |
There was a problem hiding this comment.
I like how you write the java documentation, it makes us understand your code clear. 👍
src/Duke/task/Todo.java
Outdated
|
|
||
| @Override | ||
| public void setDescription(String description) { | ||
| super.setDescription(description); |
Chenduo1412
reviewed
Sep 4, 2020
src/Duke/parser/Parser.java
Outdated
Comment on lines
47
to
48
| // return new Deadline(description, deadline); | ||
| return new Deadline(description, deadline); |
There was a problem hiding this comment.
Overall code quality is good, comment is clear, but some place can be delete.
Re-modified Constants to adhere to coding standards. Adjusted Packages
Quality is there
Chilaiping
reviewed
Sep 5, 2020
src/main/java/ui/Parser.java
Outdated
| if (description.isEmpty() || description.equals("")) { | ||
| System.out.println("Empty description for DEADLINE"); | ||
| throw new DukeException("Empty description for DEADLINE"); | ||
| } | ||
| String deadline = fullCommand.substring(idxOfBy, fullCommand.length()).substring("/by".length()).trim(); | ||
| if (deadline.isEmpty() || deadline.equals("")) { |
There was a problem hiding this comment.
I never know isEmpty command. I always checked if the string size =0. Thanks for the tips!
src/main/java/ui/Parser.java
Outdated
| int idxOfBy = fullCommand.indexOf("/at"); | ||
| if (idxOfBy < 0) { | ||
| System.out.println("Event does not contain /at"); | ||
| throw new DukeException("Event does not contain /at"); | ||
| } | ||
|
|
||
| String description = fullCommand.substring(0, idxOfBy).substring("event".length()).trim(); |
There was a problem hiding this comment.
Perhaps we can break into 2 lines for more readable code?
A-text-ui-test
branch-Level-6
Finished save function
Finished javadoc comments for this iteration
Added in find command and function
branch-Level-9
� Conflicts: � data/tasks.txt
Added in some JUnit tests
branch-A-JUnit
# Conflicts: # docs/README.md
Also added checkstyle
Also added checkstyle
Branch a gradle
Fixed all CheckStyle errors
Something is still breaking...
Okay it seems to be working now...
Branch level 10
Branch a ci
Added in relevant icon and Ui.png
Amended the README.md
Renamed Ui.png
Added in Tagging for Tasks.
Increase Code quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Adi Kesava] iP / TIC4001_Level-3 iP - PR