[Januarius Jang] iP #15
Conversation
src/main/java/Deadline.java
Outdated
|
|
||
| public Deadline (String description, String by){ | ||
| super(description); | ||
| this.by=by; |
There was a problem hiding this comment.
There should be a spacing between the assignment. ... I noticed the same issue in several other places too.
src/main/java/Deadline.java
Outdated
| } | ||
| @Override | ||
| public String toString(){ | ||
| return "[D]" + "["+ super.getStatusIcon()+ "]" + super.toString() + " (by: " + by + ")"; |
There was a problem hiding this comment.
Perhaps the return statement can be stored in a String with an appropriate name?
src/main/java/Duke.java
Outdated
|
|
||
| while(!textInput.equals("bye")) { | ||
|
|
||
| String[]arrayOfStr=textInput.split(" ",2); |
There was a problem hiding this comment.
Perhaps give this a better name to give context to the String you are storing? ... I noticed the same issue in several other places too.
src/main/java/Duke.java
Outdated
| switch (arrayOfStr[0]) { | ||
| case "list": | ||
| for (int i = 0; i < taskList.size();i++) | ||
| { |
There was a problem hiding this comment.
Java coding standard recommends Egyptian style braces
src/main/java/Duke.java
Outdated
|
|
||
| case "done": | ||
| int index=Integer.parseInt(arrayOfStr[1])-1; | ||
| taskList.get(index).markAsDone(); |
There was a problem hiding this comment.
Perhaps this can be broken down into multiple line for better readability?... I noticed the same issue in several other places too.
src/main/java/Duke.java
Outdated
|
|
||
| case "todo": | ||
| Task t=new Todo(arrayOfStr[1]); | ||
| taskList.add((t)); |
There was a problem hiding this comment.
There is no need for a double parentheses.
src/main/java/Duke.java
Outdated
|
|
||
| case "deadline": | ||
| String[]arrayOfDoneDetails=arrayOfStr[1].split("by ",2); | ||
| Task d=new Deadline(arrayOfDoneDetails[0],arrayOfDoneDetails[1] ); |
There was a problem hiding this comment.
Perhaps assign array elements into a variable with an appropriate name?
src/main/java/Duke.java
Outdated
|
|
||
| case "event": | ||
| String[]arrayOfEventDetails=arrayOfStr[1].split("at ",2); | ||
| //arrayOfDoneDetails[0] contains description, arrayOfDoneDetails[1] contains the date. |
src/main/java/Duke.java
Outdated
| BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); | ||
| String textInput = reader.readLine(); | ||
|
|
||
| while(!textInput.equals("bye")) { |
There was a problem hiding this comment.
Innovative way of ending the continuous loop
added the delete task function
Implemented Find feature
Added JUnit testing
Add gradle support
* master: Integration with GUI
* 'master' of https://github.com/JanuariusJang/ip: Delete 1.txt Add files via upload Create 1.txt
No description provided.