[Chi Lai Ping] iP #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 27, 2020 23:01
src/main/java/Duke.java
Outdated
| processInput(input, tasks); | ||
| } else { | ||
| greetNote("bye"); | ||
| return; |
There was a problem hiding this comment.
Since the main() method is void type, perhaps use "break" is better here than use "return".
src/main/java/Duke.java
Outdated
|
|
||
| try { | ||
| switch(action) { | ||
| case List: |
There was a problem hiding this comment.
I like this part as you abstract all actions to different methods. It's more readable and clear
src/main/java/Duke.java
Outdated
| } | ||
|
|
||
| static Action validateCommand(String command) throws DukeException { | ||
| if(command.startsWith("list")) { |
There was a problem hiding this comment.
The way of validating the user input commands are smart. And this method is able to be extended.
Level-6: Delete Function
This reverts commit a1e4f40.
Branch level 9
Merging branch-Level-10 to main
binbinhui
pushed a commit
to binbinhui/ip
that referenced
this pull request
Feb 19, 2021
…Guide A-UserGuide
added 5 commits
February 20, 2021 21:50
Merging A-HigherCodingQuality with added Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.