-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hong Jiancheng] iP #4
Open
HongJiancheng
wants to merge
70
commits into
nus-tic4001-AY2021S1:master
Choose a base branch
from
HongJiancheng:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
791aefd
level 0. Greet
HongJiancheng 048cb6a
level 1. Greet, Echo, Exit
HongJiancheng cf5b4ce
level 2. Add, List
HongJiancheng 950a7a7
level 3. Mark as Done
HongJiancheng 656f8cf
level 4. ToDo, Event, Deadline
HongJiancheng 8f34de9
A-TextUiTesting: Automated Text UI Testing
HongJiancheng 86fa885
Level 5. Handle Errors and A-Package
HongJiancheng 8613910
A-CodeQuality: Improve Code Quality
HongJiancheng 19fa770
A-AbstractClasses: Use Abstract Classes
HongJiancheng b694977
Merge branch 'branch-Level-5'
HongJiancheng 462c6d8
Merge branch 'master' into branch-A-CodeQuality
HongJiancheng d7907b7
Level 6. Delete
HongJiancheng f28ffc3
Merge pull request #1 from pigoliver/branch-Level-6
HongJiancheng 4c1d2f5
Merge branch 'master' of https://github.com/pigoliver/ip
HongJiancheng e968359
Level 7. Save
HongJiancheng 5b6156c
A-JavaDoc: Add JavaDoc comments
HongJiancheng 2c01efb
A-Jar: created a jar file
HongJiancheng 6c3b173
Merge branch 'branch-Level-7'
HongJiancheng d6f673c
Merge branch 'branch-A-JavaDoc'
HongJiancheng 44ef7b3
A-MoreOOP: Use More OOP
HongJiancheng c6212de
A-Packages
HongJiancheng 6e26484
Level 9. Find
HongJiancheng 2aa78f8
A-JUnit: Add JUnit Tests
HongJiancheng ffae5d3
Merge pull request #2 from pigoliver/branch-Level-9
HongJiancheng 97b1a6a
Merge branch 'master' of https://github.com/pigoliver/ip
HongJiancheng 6c0d23e
Merge pull request #3 from pigoliver/branch-A-JUnit
HongJiancheng 3718d1f
Merge branch 'master' of https://github.com/pigoliver/ip
HongJiancheng 8c83c57
Merge branch 'branch-A-Packages'
HongJiancheng d7e32d6
A-AbstractClasses: to add branch
HongJiancheng a3aedb4
Merge branch 'branch-A-AbstractClasses'
HongJiancheng 0dc4f8f
Level-8: Dates and Times
HongJiancheng cec7c71
Merge pull request #4 from pigoliver/branch-Level-8
HongJiancheng ba07565
Merge branch 'master' of https://github.com/pigoliver/ip
HongJiancheng ec9804c
A-UserGuide: Add a User Guide
HongJiancheng 4ac241a
A-Release: Repair a date saving bug discovered from testing
HongJiancheng 989c047
Edit File Directory Handling Error
HongJiancheng b83a165
A-Gradle
HongJiancheng f8bf871
Merge pull request #5 from HongJiancheng/branch-A-Gradle
HongJiancheng a32faa2
Merge branch 'master' of https://github.com/pigoliver/ip
HongJiancheng ed65a3c
A-CheckStyle
HongJiancheng 9308640
Merge pull request #6 from HongJiancheng/branch-A-StricterCodingStandard
HongJiancheng c867709
Merge branch 'master' of https://github.com/pigoliver/ip
HongJiancheng d9a97b5
Level-10
HongJiancheng b5b5b60
Merge pull request #7 from HongJiancheng/branch-Level-10
HongJiancheng 929f541
Merge branch 'master' of https://github.com/pigoliver/ip
HongJiancheng 4d2f300
Updated GUI with better view
HongJiancheng 9d41a6e
Resolve file access issue
HongJiancheng 588f009
A-CI
HongJiancheng 0859dd2
Merge pull request #8 from HongJiancheng/branch-A-CI
HongJiancheng e17ae6d
Merge branch 'master' of https://github.com/pigoliver/ip
HongJiancheng 6469034
Debug CI
HongJiancheng 4c52851
Edit gradlew executable bit
HongJiancheng 52dd10b
Checkstyle error changed
HongJiancheng 9761109
BCD-Extension: Duplicate Check
HongJiancheng c93dff9
Checkstyle resolved
HongJiancheng e3ede5a
Merge pull request #10 from HongJiancheng/branch-BCD-Extension
HongJiancheng 6112b70
Merge branch 'master' of https://github.com/pigoliver/ip
HongJiancheng 34f07b5
Better GUI with higher coding standard
HongJiancheng 59e1bf5
Merge pull request #11 from HongJiancheng/branch-A-HigherCodingQuality
HongJiancheng 184fc9b
Merge branch 'master' of https://github.com/pigoliver/ip
HongJiancheng 15c22cd
Final Enhancement with help command and duplicate command improvement
HongJiancheng 6beb872
Merge pull request #12 from HongJiancheng/branch-Final-Enhancement
HongJiancheng 725c21b
Merge branch 'master' of https://github.com/pigoliver/ip
HongJiancheng 3474ef8
Update project documents
HongJiancheng 7533eed
Merge pull request #13 from HongJiancheng/branch-Update-Website
HongJiancheng 3754307
Update DeveloperGuide.md
HongJiancheng e10a5da
Update DeveloperGuide.md
HongJiancheng e9b83dc
Set theme jekyll-theme-slate
HongJiancheng dced765
Delete Ui.PNG
HongJiancheng 7af9f3b
Add files via upload
HongJiancheng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
package Tasks; | ||
|
||
public class Deadline extends Task { | ||
protected String by; | ||
public Deadline(String description, String by){ | ||
super(description); | ||
this.by=by; | ||
} | ||
public String toString(){ | ||
return "[D]" + super.toString() + " (by: " + by + ")"; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
package Tasks; | ||
|
||
public class Event extends Task { | ||
protected String at; | ||
public Event(String description, String at){ | ||
super(description); | ||
this.at = at; | ||
} | ||
public String toString(){ | ||
return "[E]" + super.toString() + " (at: " + at + ")"; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
package Tasks; | ||
|
||
public class Todo extends Task { | ||
public Todo(String description){ | ||
super(description); | ||
} | ||
public String toString(){ | ||
return "[T]" + super.toString(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I felt these codes are highly repeated with each other, but don't know how to make it nicer.
Any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consolidate the steps (print the message, print the task) and write a new function to handle it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great! I will try to work in this direction.