[Zheng Shijie] iP #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyventus
reviewed
Sep 1, 2020
src/main/java/Duke.java
Outdated
| @@ -19,16 +19,16 @@ public static void main(String[] args) { | |||
| Scanner scanner = new Scanner(System.in); | |||
| ArrayList<Task> tasks = new ArrayList<>(); | |||
|
|
|||
| while(true){ | |||
| while (true) { | |||
There was a problem hiding this comment.
If there's a condition to exit the program, would it be better to place the condition inside here? In terms of readability.
while(! isByeCommand).
Not saying is wrong, but it would beneficial to people reading the code.
skyventus
reviewed
Sep 1, 2020
src/main/java/Duke.java
Outdated
| break; | ||
| default: | ||
| System.out.println("Command is unknown,please re-try."); | ||
| } | ||
| }catch(Exception e){ | ||
| } catch (Exception e) { | ||
| System.out.println("Internal error occurs,please re-enter the command."); |
There was a problem hiding this comment.
By catching this exception, will you be able to find out what's wrong or which function is causing the error?
And should it continue when it hit an error?
skyventus
reviewed
Sep 1, 2020
# Conflicts: # src/main/java/Duke/Tasks/ToDos.java
Chilaiping
reviewed
Sep 5, 2020
src/main/java/Duke.java
Outdated
| @@ -39,7 +39,7 @@ public static void main(String[] args) { | |||
| break; | |||
| case "done": | |||
There was a problem hiding this comment.
Maybe we should align switch statement and Case statement as suggested by Java Coding Standard?
function migration completed
Add main method to Duke.java for passing in CI
to remove unnecessary check part
remove run part only
change source compatibility
1. add extension tag 2. fixed dialog couldn't display long string bugs
Shorten methods in Duke
rectify checkstyle issue
Refine tag function, To make sure tag could be stored and load from file also.
Refine GUI: add background pic, adjust font size adjust button background
1. resolve compatibility issue on font 2. optimize logic, enter bye will exit the program directly
Add GUI description Add tag functionality
refine user guide
refine user guide
Create README landing page
1st draft of Developer Guide
add architecture diagram and update developer guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.