Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kustomization.yaml files to new format #387

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

thunderboltsid
Copy link
Contributor

@thunderboltsid thunderboltsid commented Mar 12, 2024

kustomize has deprecated the older format which our older kustomization files were based on. These older format files were leading to a lot of deprecation warnings from kustomize during our build processes.

We used kustomize edit fix command to update our old kustomize files to our new kustomize files. This PR was largely auto-generated using the following command.

$ find . -type d -exec bash -c 'cd {} && kustomize edit fix' \;

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.63%. Comparing base (9ccfa89) to head (82f54f1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #387   +/-   ##
=======================================
  Coverage   25.63%   25.63%           
=======================================
  Files          19       19           
  Lines        1303     1303           
=======================================
  Hits          334      334           
  Misses        969      969           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deepakm-ntnx
Copy link
Contributor

/hold

@deepakm-ntnx
Copy link
Contributor

deepakm-ntnx commented Mar 12, 2024

pls hold this change till we merge https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/pull/386/files as we are changing many yamls there as well. you can assign it to me so that i can do it after that

@thunderboltsid
Copy link
Contributor Author

pls hold this change till we merge d2iq-labs/capi-runtime-extensions#384 as these are easy to make changes than the one done in d2iq-labs/capi-runtime-extensions#384

This changes the format of kustomization.yaml files to the ones expected by kustomize. This is pretty much an auto-generated change from kustomize linter. Can you clarify why the other PR is a blocker for this PR?

@deepakm-ntnx
Copy link
Contributor

deepakm-ntnx commented Mar 12, 2024

pls hold this change till we merge d2iq-labs/capi-runtime-extensions#384 as these are easy to make changes than the one done in d2iq-labs/capi-runtime-extensions#384

This changes the format of kustomization.yaml files to the ones expected by kustomize. This is pretty much an auto-generated change from kustomize linter. Can you clarify why the other PR is a blocker for this PR?

since we are making more changes in #386
we can do this after above is merged

@thunderboltsid
Copy link
Contributor Author

That makes sense. Given these changes are auto-generated anyway, it's easy enough to run the command again once the other PR is merged.

@thunderboltsid
Copy link
Contributor Author

/hold cancel

@thunderboltsid
Copy link
Contributor Author

/retest

@thunderboltsid
Copy link
Contributor Author

/test e2e-nutanix-features

kustomize has deprecated the older format which our older kustomization files were based on. These older format files were leading to a lot of deprecation warnings from kustomize during our build processes.

We used kustomize edit fix command to update our old kustomize files to our new kustomize files. This PR was largely auto-generated using the following command.

```
$ find . -type d -exec bash -c 'cd {} && kustomize edit fix' \;
```
@thunderboltsid thunderboltsid merged commit b7bd47d into main Mar 26, 2024
6 of 7 checks passed
@thunderboltsid thunderboltsid deleted the jira/krbn-8072 branch March 26, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants