fix: downgrade Calico to v3.26.4 #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
force-pushed
the
dkoshkin/calico-downgrade
branch
from
da7bbe4
to
fb32422
Compare
dkoshkin
changed the title
The cleanup Job is getting run and deleting the Installation. The Installation object won't be recreated until the CRS controller periodically reconciles. https://github.com/projectcalico/calico/pull/7859/files
dkoshkin
force-pushed
the
dkoshkin/calico-downgrade
branch
from
fb32422
to
fe55a2f
Compare
dkoshkin
changed the title
faiq
approved these changes
Feb 11, 2024
Let's do it! |
jimmidyson
approved these changes
Feb 12, 2024
Merged
dkoshkin
pushed a commit
that referenced
this pull request
Feb 12, 2024
🤖 I have created a release *beep* *boop* --- ## 0.4.0 (2024-02-12) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Support multiple registry credentials if specified by @jimmidyson in #343 * feat: Add Cilium CNI addon support by @jimmidyson in #333 ### Fixes 🔧 * fix: downgrade Calico to v3.26.4 by @dkoshkin in #348 * fix: AMI ID patch by @dkoshkin in #345 * fix: use correct AWS EBS CSI images by @dkoshkin in #344 ### Other Changes * build(main): Latest devbox update (2024-02-12) by @d2iq-labs-actions-pr-bot in #349 * build: Fix up lint config for moved external APIs by @jimmidyson in #355 * test: add a Makefile target to update image by @dkoshkin in #346 **Full Changelog**: v0.3.5...v0.4.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
supershal
reviewed
Feb 12, 2024
| version = "0.0.1-dev"; | ||
| src = fetchFromGitHub { | ||
| owner = "jimmidyson"; | ||
| repo = "goprintconst"; |
There was a problem hiding this comment.
This is a fork of @dlipovetsky with one important fix to support aliased consts - happy to switch to @dlipovetsky's repo if he merges my PR ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cleanup Job is getting run and deleting the Installation. The Installation object won't be recreated until the CRS controller periodically reconciles.
There are other issues with this feature:
Introduced in https://github.com/projectcalico/calico/pull/7859/files
Not using v3.26.4 intentionally since DKP still has it set to v3.26.3, and because this template is in json the tooling does not properly get the list of images for Calico.Since the bastion images need to be rebuilt, we can include the Calico bump in there too.I still think this project should publish a list of images that can be consumed by other tools.