build: Include Calico images in image list #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhrabovcin
previously approved these changes
Sep 9, 2024
|
This PR/issue depends on:
|
thunderboltsid
approved these changes
Sep 9, 2024
Calico images are deployed by the tigera-operator and as such are not discoverable by the helm list images plugin. Using the extra images file functionality of the helm list images plugin allows for adding these images as templated strings that will adapt with the chart version as it is updated in future. This commit also fixes up some other things: - Use `filepath` instead of `path` for portabiity - Output the image list to stdout from make to allow user to decide where to redirect list to - Omit changing dir from image list when running as goreleaser hook - Slightly more defensive when checkinbg errors
jimmidyson
force-pushed
the
jimmi/calico-images
branch
from
0fe0c98
to
9d0b7a7
Compare
thunderboltsid
approved these changes
Sep 9, 2024
mhrabovcin
approved these changes
Sep 9, 2024
Merged
dlipovetsky
pushed a commit
that referenced
this pull request
Sep 25, 2024
🤖 I have created a release *beep* *boop* --- ## 0.16.0 (2024-09-25) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Build with go 1.23 by @jimmidyson in #889 * feat: Enable Hubble Relay in Cilium deployment via CAAPH by @dlipovetsky in #899 * feat: Extract CAAPH values templates to files by @jimmidyson in #896 * feat: Build with go 1.23.1 by @jimmidyson in #913 * feat: Support node taints per nodepool and control plane by @jimmidyson in #909 ### Fixes 🔧 * fix: Remove deprecated toleration for node-role.kubernetes.io/master by @jimmidyson in #895 * fix: Do not use digests for Cilium images by @jimmidyson in #901 ### Other Changes * test: Bump Kubernetes versions for tests by @jimmidyson in #893 * ci: images tool by @faiq in #822 * build: Include Calico images in image list by @jimmidyson in #903 * build: Use upstream packages again from upstream by @jimmidyson in #908 * ci(main): enable creating release-please PR from release branches by @supershal in #912 * docs: Enable dark mode, add Nutanix color, and header links by @jimmidyson in #915 **Full Changelog**: v0.15.0...v0.16.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calico images are deployed by the tigera-operator and as such are not
discoverable by the helm list images plugin. Using the extra images file
functionality of the helm list images plugin allows for adding these
images as templated strings that will adapt with the chart version as it
is updated in future.
This commit also fixes up some other things:
filepathinstead ofpathfor portabiitywhere to redirect list to
Depends on #822.