Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release/v0.14.x): enable creating release-please PR from release branches #911

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

supershal
Copy link
Contributor

What problem does this PR solve?:

  • enable creating first release-please PR for release branches
  • change CAREN e2e config to use version 0.14.x

How Has This Been Tested?:

on branches other than main and release/*

make release-please
make/dev.mk:49: *** "release-please should only be run on the main or release branch".  Stop.

on release/v0.1.4.x branch
#910

Special notes for your reviewer:

@supershal supershal changed the title ci: enable createing release-please PR from release branches ci(release/v0.14.x): enable createing release-please PR from release branches Sep 17, 2024
@supershal supershal self-assigned this Sep 17, 2024
make/dev.mk Outdated Show resolved Hide resolved
Copy link
Member

@jimmidyson jimmidyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as on other PR, please update release doc with necessary changes for devs to understand what to do here for release branches.

@jimmidyson jimmidyson changed the title ci(release/v0.14.x): enable createing release-please PR from release branches ci(release/v0.14.x): enable creating release-please PR from release branches Sep 18, 2024
Copy link
Contributor

@dlipovetsky dlipovetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if we could maintain release tooling on the main branch only, but after speaking with @supershal, I understood that wouldn't work with release-please.

@supershal supershal merged commit a039691 into release/v0.14.x Sep 19, 2024
17 checks passed
@supershal supershal deleted the shalin/release-please-0.14.x branch September 19, 2024 19:02
supershal added a commit that referenced this pull request Oct 2, 2024
🤖 I have created a release *beep* *boop*
---


## 0.14.9 (2024-10-02)

<!-- Release notes generated using configuration in .github/release.yaml
at release/v0.14.x -->

## What's Changed
### Fixes 🔧
* fix: [release/v0.14.x] Rename webhook container to manager by
@jimmidyson in
#933
* fix: [release/v0.14.x] Introduce startup probe to CAREN pod to reduce
races by @jimmidyson in
#934
### Other Changes
* ci(release/v0.14.x): enable creating release-please PR from release
branches by @supershal in
#911
* test(e2e): [release/v0.14.x] Use released rocky image by @jimmidyson
in
#935


**Full Changelog**:
v0.14.8...v0.14.9

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants