Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [release/v0.14.x] Rename webhook container to manager #933

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix: [release/v0.14.x] Rename webhook container to manager #933

merged 1 commit into from
Oct 2, 2024

Commits on Oct 2, 2024

  1. fix: Rename webhook container to manager (#932) 

    The clusterctl logic to wait for providers to be ready depends on the
container name being manager (see
https://github.com/kubernetes-sigs/cluster-api/blob/main/cmd/clusterctl/internal/util/objs.go#L181)
otherwise it will not wait for the provider to be ready and hence
potentially
return too early for other client operations.
    @jimmidyson
    jimmidyson committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    2e73935 View commit details
    Browse the repository at this point in the history