Accept local decimal separator for the weight field. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agreed! I'm somewhat suprised that this issue had not been identified long ago. Note: this regional number decimal marker issue surfaced a number details which needed to be implemented more cohesively between data entry, HealthKit sync, database normalized form and import/export format. An overall fix has been checked. This fix is now being tested. You are welcome also build and test the repository version, if you wish. Commit: 974796d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've spotted an issue while inserting weight for users that have
,as the decimal separator. They can't insert a decimal number using the on-screen numeric keyboard as it does not have a key with the period.symbol and using a,is an invalid input. One can work around this issue by typing their weight in another app and pasting it into the weight field. I believe this is really disruptive experience for users and wanted to fix it.To fix that issue I've used a number formatter to convert the weight string into a double.
Screenshot of the numeric keyboard with the
,separator: