Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept local decimal separator for the weight field. #57

Conversation

ZofiaBernadetta
Copy link

I've spotted an issue while inserting weight for users that have , as the decimal separator. They can't insert a decimal number using the on-screen numeric keyboard as it does not have a key with the period . symbol and using a , is an invalid input. One can work around this issue by typing their weight in another app and pasting it into the weight field. I believe this is really disruptive experience for users and wanted to fix it.

To fix that issue I've used a number formatter to convert the weight string into a double.

Screenshot of the numeric keyboard with the , separator:

@marc-medley marc-medley self-assigned this Aug 2, 2021
@marc-medley marc-medley added the bug Indicates an unexpected problem or unintended behavior. label Aug 2, 2021
@marc-medley marc-medley added this to the v3.2.11 milestone Aug 2, 2021
@marc-medley marc-medley linked an issue Aug 2, 2021 that may be closed by this pull request
@marc-medley
Copy link
Member

I believe this is really disruptive experience for users and wanted to fix it.

Agreed! I'm somewhat suprised that this issue had not been identified long ago.

Note: this regional number decimal marker issue surfaced a number details which needed to be implemented more cohesively between data entry, HealthKit sync, database normalized form and import/export format.

An overall fix has been checked. This fix is now being tested. You are welcome also build and test the repository version, if you wish.

Commit: 974796d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add comma support for weight input
2 participants