v1.5 #17
v1.5 #17
Conversation
… contract StableAssetApplication.
contracts/WtapETH.sol
Outdated
| _mint(msg.sender, _wtapETHAmount); | ||
| tapETH.transferFrom(msg.sender, address(this), _tapETHAmount); |
There was a problem hiding this comment.
| _mint(msg.sender, _wtapETHAmount); | |
| tapETH.transferFrom(msg.sender, address(this), _tapETHAmount); | |
| tapETH.transferFrom(msg.sender, address(this), _tapETHAmount); | |
| _mint(msg.sender, _wtapETHAmount); |
There was a problem hiding this comment.
in term of security pattern , we should have
_mint(msg.sender, _wtapETHAmount);
tapETH.transferFrom(msg.sender, address(this), _tapETHAmount);
contracts/StableAsset.sol
Outdated
| * @notice This function allows to rebase TapETH by increasing his total supply | ||
| * from the current stableSwap pool by the staking rewards and the swap fee. | ||
| */ | ||
| function rebase() external returns (uint256) { |
There was a problem hiding this comment.
I'm not sure why do we even need this method. The pool collects yield basically on every transaction.
There was a problem hiding this comment.
In the case where we don't have activity on Tapio ( no user transactions) and we continuel receiving staking rewards, we need to be able to rebase.
* Add setTotalSupply * Remove FeeCollected event * Add SharesMinted event --------- Co-authored-by: zjb0807 <zjb0807@qq.com> Co-authored-by: Mars12-dev <75334564+Mars12-dev@users.noreply.github.com>
update buffer feature
Add totalRewards and event on tapETH
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
========================================
- Coverage 0.52% 0.45% -0.07%
========================================
Files 13 14 +1
Lines 1343 1524 +181
Branches 301 325 +24
========================================
Hits 7 7
- Misses 1335 1516 +181
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Fix amount in YieldCollected
I created v1.0 branch from main branch.