Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] @cloudinary-util/types@1.0.1, Video Player 1.10.6 #194

Closed
colbyfayock opened this issue Mar 13, 2024 · 1 comment · Fixed by #200
Closed

[Feature] @cloudinary-util/types@1.0.1, Video Player 1.10.6 #194

colbyfayock opened this issue Mar 13, 2024 · 1 comment · Fixed by #200
Labels
enhancement New feature or request

Comments

@colbyfayock
Copy link
Collaborator

@cloudinary-util/types was updated to 1.0.1 which simply includes a new prop to add picture-in-picture to the CldVideoPlayer

This requires an update to the Cloudinary Video Player script to 1.10.6

This assumes that the @cloudinary-util/types has already been pulled in to manage CldVideoPlayer types, if not that's a prerequisite
https://github.com/cloudinary-community/next-cloudinary/pull/421/files

Would be great to:

  • Pull in the new type to make it available to the component
  • Add an example for CldVideoPlayer that shows it in action

Related:

@colbyfayock colbyfayock added the enhancement New feature or request label Mar 13, 2024
@Baroshem
Copy link
Collaborator

Hey Colby,

Thanks for reporting this issue. I will make sure to include it in the next release :)

This was linked to pull requests Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants